This is an automated email from the ASF dual-hosted git repository.

markt-asf pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/11.0.x by this push:
     new 65a3cf6b88 Comment out tests rather than use @Ignore
65a3cf6b88 is described below

commit 65a3cf6b8883b97ac24c5fd6613b8fb182a48344
Author: Mark Thomas <[email protected]>
AuthorDate: Fri Jun 19 10:17:26 2026 +0100

    Comment out tests rather than use @Ignore
    
    Avoids triggering 'skipped tests' messages in test output
---
 .../apache/el/parser/TestELParserPerformance.java  | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/test/org/apache/el/parser/TestELParserPerformance.java 
b/test/org/apache/el/parser/TestELParserPerformance.java
index 85eac64240..85874d7dfc 100644
--- a/test/org/apache/el/parser/TestELParserPerformance.java
+++ b/test/org/apache/el/parser/TestELParserPerformance.java
@@ -29,7 +29,6 @@ import jakarta.el.ExpressionFactory;
 import jakarta.el.ValueExpression;
 
 import org.junit.Assert;
-import org.junit.Ignore;
 import org.junit.Test;
 
 import org.apache.tomcat.util.collections.SynchronizedStack;
@@ -99,9 +98,12 @@ public class TestELParserPerformance extends ELBaseTest {
     /*
      * Ignored by default since this is an absolute test primarily for
      * https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
+     *
+     * Comment out @Test rather than use @Ignore since @Ignore triggers a 
"skipped test" message in the test output
+     * and those messages should be reserved for tests skipped due to 
environmental (no APR, wrong Java version, etc)
+     * issues.
      */
-    @Ignore
-    @Test
+    //@Test
     public void testAstAnd() {
 
         ELManager manager = new ELManager();
@@ -145,9 +147,12 @@ public class TestELParserPerformance extends ELBaseTest {
     /*
      * Ignored by default since this is an absolute test primarily for
      * https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
+     *
+     * Comment out @Test rather than use @Ignore since @Ignore triggers a 
"skipped test" message in the test output
+     * and those messages should be reserved for tests skipped due to 
environmental (no APR, wrong Java version, etc)
+     * issues.
      */
-    @Ignore
-    @Test
+    //@Test
     public void testAstNotEmpty() {
 
         ELManager manager = new ELManager();
@@ -214,9 +219,12 @@ public class TestELParserPerformance extends ELBaseTest {
      *
      * Ignored by default since this is an absolute test primarily for
      * https://bz.apache.org/bugzilla/show_bug.cgi?id=69381
+     *
+     * Comment out @Test rather than use @Ignore since @Ignore triggers a 
"skipped test" message in the test output
+     * and those messages should be reserved for tests skipped due to 
environmental (no APR, wrong Java version, etc)
+     * issues.
      */
-    @Ignore
-    @Test
+    //@Test
     public void testExpressions() throws Exception {
 
         ELManager manager = new ELManager();


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to