This is an automated email from the ASF dual-hosted git repository.
markt-asf pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 1cd97dbc44 Comment out tests rather than use @Ignore
1cd97dbc44 is described below
commit 1cd97dbc44d0c57654e80cd71eaed3d1b6f168c7
Author: Mark Thomas <[email protected]>
AuthorDate: Fri Jun 19 10:17:26 2026 +0100
Comment out tests rather than use @Ignore
Avoids triggering 'skipped tests' messages in test output
---
.../apache/el/parser/TestELParserPerformance.java | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/test/org/apache/el/parser/TestELParserPerformance.java
b/test/org/apache/el/parser/TestELParserPerformance.java
index 49edcc0517..6e5cbf887c 100644
--- a/test/org/apache/el/parser/TestELParserPerformance.java
+++ b/test/org/apache/el/parser/TestELParserPerformance.java
@@ -28,7 +28,6 @@ import jakarta.el.ExpressionFactory;
import jakarta.el.ValueExpression;
import org.junit.Assert;
-import org.junit.Ignore;
import org.junit.Test;
import org.apache.tomcat.util.collections.SynchronizedStack;
@@ -98,9 +97,12 @@ public class TestELParserPerformance {
/*
* Ignored by default since this is an absolute test primarily for
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
+ *
+ * Comment out @Test rather than use @Ignore since @Ignore triggers a
"skipped test" message in the test output
+ * and those messages should be reserved for tests skipped due to
environmental (no APR, wrong Java version, etc)
+ * issues.
*/
- @Ignore
- @Test
+ //@Test
public void testAstAnd() {
ELManager manager = new ELManager();
@@ -144,9 +146,12 @@ public class TestELParserPerformance {
/*
* Ignored by default since this is an absolute test primarily for
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69338
+ *
+ * Comment out @Test rather than use @Ignore since @Ignore triggers a
"skipped test" message in the test output
+ * and those messages should be reserved for tests skipped due to
environmental (no APR, wrong Java version, etc)
+ * issues.
*/
- @Ignore
- @Test
+ //@Test
public void testAstNotEmpty() {
ELManager manager = new ELManager();
@@ -213,9 +218,12 @@ public class TestELParserPerformance {
*
* Ignored by default since this is an absolute test primarily for
* https://bz.apache.org/bugzilla/show_bug.cgi?id=69381
+ *
+ * Comment out @Test rather than use @Ignore since @Ignore triggers a
"skipped test" message in the test output
+ * and those messages should be reserved for tests skipped due to
environmental (no APR, wrong Java version, etc)
+ * issues.
*/
- @Ignore
- @Test
+ //@Test
public void testExpressions() throws Exception {
ELManager manager = new ELManager();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
