On Fri, Aug 14, 2026 at 2:58 PM Coty Sutherland <[email protected]> wrote:

>
> On Fri, Aug 14, 2026 at 2:36 PM Coty Sutherland <[email protected]>
> wrote:
>
>>
>>
>> On Thu, Aug 13, 2026 at 8:17 AM Christopher Schultz <
>> [email protected]> wrote:
>>
>>> Rainer,
>>>
>>> On 8/12/26 10:28 PM, Rainer Jung wrote:
>>>  > [...]>
>>>  >
>>> > About the second one, I am not so sure:
>>> >
>>> > org.apache.catalina.startup.TestWithoutClustering
>>> >
>>> > Testcase: testStoreRegistryWithoutClustering took 0.029 sec
>>> >          Caused an ERROR
>>> > null
>>> > java.lang.ExceptionInInitializerError
>>> >          at
>>> java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>>> >          at
>>> >
>>> org.apache.catalina.startup.TestWithoutClustering.testStoreRegistryWithoutClustering(TestWithoutClustering.java:313)
>>> > Caused by: java.lang.NullPointerException
>>> >          at
>>> >
>>> org.apache.tomcat.util.res.StringManager.getManager(StringManager.java:186)
>>> >          at
>>> >
>>> org.apache.catalina.storeconfig.StoreRegistry.<clinit>(StoreRegistry.java:50)
>>> >
>>> > There seems to be no relevant change around StoreRegistry or
>>> > StringManager and the pattern seems to be used the same way in many
>>> > places. If seems the class StoreRegistry is incomplete during its
>>> static
>>> > initializers and getPackage() may return null, but why didn't I see
>>> this
>>> > anywhere before?
>>>
>>> I think this is a new test Coty has been working on. I'd say it's not a
>>> showstopper at all.
>>>
>>
>> Yeah, it was introduced in a commit just with the new test, so if they're
>> not working correctly for some older version I'd say its fine. I'll look
>> into it too though.
>>
>
> Fixed in
> https://github.com/apache/tomcat/commit/567d4707d1cc815bbd554b7aaf45b91ff0d54cd9
> (thanks Claude)
>

Oh and I'm not planning to apply that fix to 10.1+ since it only affects
tomcat 9, unless we think its a good idea to stay consistent.


>
>
>>
>>
>>>
>>> -chris
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>>
>>>

Reply via email to