csutherl opened a new pull request, #1057:
URL: https://github.com/apache/tomcat/pull/1057

   Probing the optional native/OpenSSL libraries in `ServerInfo.main()` 
triggers their initialization, which logged `java.util.logging` messages into 
the version output. The last attempt to address this lowered two parent loggers 
to WARNING, but WARNING did not suppress the SEVERE "incompatible Tomcat Native 
version" message, and no strong reference was kept to the loggers so the 
configured level could be garbage collected before the init code logged.
   
   This change adds a capturing handler to the loggers involved with 
`useParentHandlers=false` so nothing reaches the console, retaining strong 
references to avoid the weak-reference GC issue. Then the captured 
incompatible-version message from tomcat-native is re-emitted under "APR 
loaded: false" so that outcome is no longer unexplained and gives a clear 
action step before they may run into the problem at runtime.
   
   As an alternate approach that's much simpler we could simply ignore the WARN 
and output `APR loaded: false` without any additional information for the user. 
Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to