csutherl commented on code in PR #1057:
URL: https://github.com/apache/tomcat/pull/1057#discussion_r3926699202
##########
java/org/apache/catalina/util/ServerInfo.java:
##########
@@ -63,6 +67,16 @@
*/
private static final String serverNumber;
+ /**
+ * Strong references to the loggers reconfigured by {@link #main(String[])}
+ * while probing the optional native/OpenSSL libraries. Retained because
+ * java.util.logging holds only weak references to {@link Logger}
instances;
+ * an otherwise unreferenced Logger could be garbage collected (discarding
+ * the capturing handler and {@code useParentHandlers=false} configured on
+ * it) before the library initialization code logs.
+ */
+ private static final List<Logger> capturedLoggers = new ArrayList<>();
Review Comment:
I'm sure we could. I guess it's complaining because it's only used in
`main()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
