arturobernalg commented on PR #1136: URL: https://github.com/apache/tomcat/pull/1136#issuecomment-6691939892
Tested locally on current main with JDK 21 and Ant 1.10.15. Reproduced the issue: with a `core.autocrlf=true` checkout, main generates the `.sh` files with CRLF and `output/build/bin/version.sh` fails on Linux with "bad interpreter: /bin/sh^M". With the patch, the `.sh` files are LF, the `.bat` files are CRLF, and the script runs. I also built the tgz, zip, windows-x64 zip, deployer and fulldocs packages with and without the patch and compared every entry: only the JARs differ (build time), and all `.sh`/`.bat` files and modes are identical. I couldn't build the Windows installer (no makensis available). The `changelog` conflicts with main and credits (strongox), which isn't a committer initial. I'd leave that to a committer. Otherwise, looks good. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
