markt-asf commented on PR #1136:
URL: https://github.com/apache/tomcat/pull/1136#issuecomment-6857653033
I don't believe there has been a request to modify line-endings in
output/build before. I don't see any reason not to do that.
The aim has always been minimal developer and user friction. Developers want
text files to have the right line-ending for their platform. Developers and
users want the *.sh/*.bat files to just work.
*.tar.gz has always been primarily for Linux and friends and *.zip for
Windows.
With that in mind, I think the desired endpoint is:
- text files in the *-src.tar.gz distribution should all use LF
- text files in the *-src.zip distribution should all use CRLF
- text files in binary *.tar.gz distributions should all use LF except
*.bat files which should use CRLF
- text files in binary *.zip distributions should all use CRLF except *.sh
files which should use LF
- line endings for text files in output/build should be unchanged except
that *.bat should use CRLF and *.sh should use LF
I need to check that against the current implementation and any prior bug
reports and/or PRs.
My (possibly mistaken) impression from scanning through build.xml was that
there were more calls to fixcrlf than were strictly necessary. I'll look at
that as well.
As an aside, the current change log edit in this PR looks like a prior
rebase went wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
