Hi, 2014-10-29 20:28 GMT+02:00 Rémy Maucherat <r...@apache.org>: > > 2014-10-29 19:22 GMT+01:00 Mark Thomas <ma...@apache.org>: > > > OK. Try again :) > > > > -1 veto. > > > > This breaks a requirement of the Servlet 3.1 spec that an ISE should be > > thrown if get[Request|Response]() is called after complete() is called. > > > > This commit breaks the unit tests that check this (the calls do not > > thrown any exception). > > > > The commit did not include any test cases. What problem are you trying > > to solve? And where in the spec does it mandate the behaviour you are > > trying to achieve? > > > > The problem I am trying to solve is that the listener onComplete should be > able to call getResponse and write things. Basically complete is not done > until onComplete is done.
If I remember correctly the change for onComplete was introduced because of https://issues.apache.org/bugzilla/show_bug.cgi?id=56190 Regards, Violeta > > Rémy
