2014-10-29 20:27 GMT+01:00 Mark Thomas <[email protected]>: > OK. Lets leave it in place until the issues with the tests are fixed. > > The started flag being true for the MUST_COMPLETE state is causing > problems too. It breaks code like this: > > if (request.isAsyncStarted()) { > request.getAsyncContext().complete(); > } > > While you could make the "effects of complete have to be delayed..." > argument, I don't think it holds in this case as the ability to test if > complete() needs to be called is more important. > > What do you think about reverting that particular change? > > It's the same thing, the started flag should be true until the end of the processing of complete, which means for example for code like: ac.complete(); println("" + ac.isAsyncStarted());
It should display "true" rather than "false". I'll add the strict flag as well for that. Rémy
