Filip, On 12/11/14 3:08 PM, Filip Hanik wrote: > Mr Schultz, nothing prevents you from removing the spaces if you at the > same time fix the formatting or provide a solution to it. > I do agree, that the spaces in the code for the sake of formatting is > pretty lame, as it makes for erroneous copy/paste.
I hadn't realized that the spaces were there to handle formatting (which I agree is unfortunate and kinda hacky, but what are you gonna do?). The reason I removed the spaces was so copy/paste would work if a user blindly copy/pasted the property name into a script, etc. I'll revert the patch and see if I can come up with something that works across browsers (which probably doesn't exist). Thanks, -chris > On Thu, Dec 11, 2014 at 1:03 PM, Mark Thomas <ma...@apache.org> wrote: > >> On 11/12/2014 19:49, schu...@apache.org wrote: >>> Author: schultz >>> Date: Thu Dec 11 19:49:25 2014 >>> New Revision: 1644737 >>> >>> URL: http://svn.apache.org/r1644737 >>> Log: >>> Removed extraneous spaces from system property keys. >> >> -1. >> >> Those spaces are there for a good reason - it makes the page readable. >> The other system properties have them too. >> >> Mark >> >> >>> >>> Modified: >>> tomcat/trunk/webapps/docs/config/systemprops.xml >>> >>> Modified: tomcat/trunk/webapps/docs/config/systemprops.xml >>> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=1644737&r1=1644736&r2=1644737&view=diff >>> >> ============================================================================== >>> --- tomcat/trunk/webapps/docs/config/systemprops.xml (original) >>> +++ tomcat/trunk/webapps/docs/config/systemprops.xml Thu Dec 11 19:49:25 >> 2014 >>> @@ -597,32 +597,32 @@ >>> >>> <properties> >>> >>> - <property name="org.apache.tomcat >> .websocket.ALLOW_UNSUPPORTED_EXTENSIONS"> >>> + <property >> name="org.apache.tomcat.websocket.ALLOW_UNSUPPORTED_EXTENSIONS"> >>> <p>If <code>true</code>, allow unknown extensions to be declared >> by >>> the user.</p> >>> <p>The default value is <code>false</code>.</p> >>> </property> >>> >>> - <property name="org.apache.tomcat. >> websocket.DEFAULT_ORIGIN_HEADER_VALUE"> >>> + <property >> name="org.apache.tomcat.websocket.DEFAULT_ORIGIN_HEADER_VALUE"> >>> <p>Default value of the origin header that will be sent by the >> client >>> during the upgrade handshake.</p> >>> <p>The default is null so that no origin header is sent.</p> >>> </property> >>> >>> - <property name="org.apache.tomcat. >> websocket.DEFAULT_PROCESS_PERIOD"> >>> + <property name="org.apache.tomcat.websocket.DEFAULT_PROCESS_PERIOD"> >>> <p>The number of periodic ticks between periodic processing which >>> involves in particular session expiration checks.</p> >>> <p>The default value is <code>10</code> which corresponds to 10 >>> seconds.</p> >>> </property> >>> >>> - <property name="org.apache.tomcat. >> websocket.DISABLE_BUILTIN_EXTENSIONS"> >>> + <property >> name="org.apache.tomcat.websocket.DISABLE_BUILTIN_EXTENSIONS"> >>> <p>If <code>true</code>, disable all built-in extensions provided >> by the >>> server, such as message compression.</p> >>> <p>The default value is <code>false</code>.</p> >>> </property> >>> >>> - <property name="org.apache.tomcat. >> websocket.STREAMS_DROP_EMPTY_MESSAGES"> >>> + <property >> name="org.apache.tomcat.websocket.STREAMS_DROP_EMPTY_MESSAGES"> >>> <p>If <code>true</code>, streams provided to the user (writer and >> output >>> stream) will not send an empty message when flushing and there is >> no >>> data to flush, or when it is closed without having been used (for >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> >
signature.asc
Description: OpenPGP digital signature
