I think even if not mandatory when migrating a sample we should check if we need to add a test for it or not since the target is to remove examples from trunk IMHO. Just a little review which is not that hard but needs to be done otherwise we'll never do it. Think it would be great before going on tomee 2 (so we have few time for it). Last point: this can be done by anyone actually even newcomers. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
2014-04-01 20:15 GMT+02:00 Gerhard Petracek <[email protected]>: > i had a short discussion with romain about it. > > a possible approach: > #1 rename 'examples' to something like 'itests' > #2 separated github mirror just for examples (-> copy real examples step by > step) > > regards, > gerhard > > > > 2014-03-29 18:43 GMT+01:00 Romain Manni-Bucau <[email protected]>: > >> well actually we can just activate the "fast" profile by default and >> keep the current default for CI (that's already the case since >> -Pall-adapters is only on buildbot) >> >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmannibucau.wordpress.com/ >> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> Github: https://github.com/rmannibucau >> >> >> >> 2014-03-29 16:43 GMT+01:00 helio frota <[email protected]>: >> > If we move the examples out to their own "repo" and mirrored it on >> Github, >> > we might get a lot more contributions. >> > >> > +1 >> > >> > Thoughts? >> > >> > IMHO, examples are not part of a project, in the meaning of "to build" >> > and/or "to validate". >> > For me, the validation is a real project in production, joining all >> > "examples" in a real project to catch a lot of problems as possible. >> > >> > Other thing is the community... a lot of new people never used SVN >> before, >> > put examples on github to get more feedback and more contributions, can >> > open a large door for TomEE. So, the project can have a lot of >> contributors >> > and accelerate more the community "X factor". >> > >> > I guess the dev team need to think/remember about this: "No community, no >> > success". Community is a little bit diff from just users. >> > >> > >> > thanks >> > >> > >> > >> > >> > >> > ------------------------------------------- >> > http://eprogramming.github.io >> > >> > >> > >> > On Sat, Mar 29, 2014 at 6:52 AM, Jonathan Gallimore < >> > [email protected]> wrote: >> > >> >> It wouldn't surprise me if that's already there. :) >> >> >> >> If that's the case, it's probably worth a mention here: >> >> http://tomee.apache.org/dev/source-code.html >> >> >> >> Happy to add that when I get a chance to get on the computer this >> evening. >> >> >> >> Jon >> >> >> >> > On 29 Mar 2014, at 09:34, Romain Manni-Bucau <[email protected]> >> >> wrote: >> >> > >> >> > isnt it what does main profile? >> >> > Romain Manni-Bucau >> >> > Twitter: @rmannibucau >> >> > Blog: http://rmannibucau.wordpress.com/ >> >> > LinkedIn: http://fr.linkedin.com/in/rmannibucau >> >> > Github: https://github.com/rmannibucau >> >> > >> >> > >> >> > >> >> > 2014-03-29 10:33 GMT+01:00 Jonathan Gallimore < >> >> [email protected]>: >> >> >> Good points I think. I'd like to see a quicker build, but having >> those >> >> tests as part of the main build is useful. >> >> >> >> >> >> Maybe we can exclude them with a profile and publish the Maven >> command >> >> to build without them? Might be a simple solution to get the best of >> both >> >> worlds? >> >> >> >> >> >> Jon >> >> >> >> >> >>> On 29 Mar 2014, at 08:55, Andy <[email protected]> wrote: >> >> >>> >> >> >>> I agree with Romain that the example tests are an important way of >> >> judging if the build is stable. In the past I have always based internal >> >> releases on them all passing. >> >> >>> >> >> >>> If we moved them then I'd still like to see them on the buildbot. >> >> >>> >> >> >>> We could also just leave them in trunk and mirror just the examples >> so >> >> that we can merge changes back. >> >> >>> >> >> >>>> On 29.03.2014 09:37, Romain Manni-Bucau wrote: >> >> >>>> -100 excepted if for *each* example you move tests to main build >> too. >> >> >>>> Romain Manni-Bucau >> >> >>>> Twitter: @rmannibucau >> >> >>>> Blog: http://rmannibucau.wordpress.com/ >> >> >>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> >> >>>> Github: https://github.com/rmannibucau >> >> >>>> >> >> >>>> >> >> >>>> >> >> >>>> 2014-03-29 9:35 GMT+01:00 Jean-Louis MONTEIRO <[email protected] >> >: >> >> >>>>> +1 >> >> >>>>> Le 29 mars 2014 06:01, "Thiago Veronezi" <[email protected]> a >> >> écrit : >> >> >>>>> >> >> >>>>>> +1 >> >> >>>>>> Was chatting with Gerhard at JavaLand and he mentioned moving >> >> examples to >> >> >>>>>> its own section of the repository. >> >> >>>>>> >> >> >>>>>> In our github mirror, we actually have quite a few people looking >> >> (110 >> >> >>>>>> forks, 34 stars) >> >> >>>>>> >> >> >>>>>> - https://github.com/apache/tomee >> >> >>>>>> >> >> >>>>>> If we move the examples out to their own "repo" and mirrored it >> on >> >> Github, >> >> >>>>>> we might get a lot more contributions. >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> Thoughts? >> >> >>>>>> >> >> >>>>>> >> >> >>>>>> -David >> >> >>> >> >> >>> >> >> >>> -- >> >> >>> Andy Gumbrecht >> >> >>> Tomitribe Corporation >> >> >>> http://www.tomitribe.com >> >> >>> >> >> >>
