I'll do it tomorrow if that's OK, mobile at the moment Andy. -- Andy Gumbrecht http://www.tomitribe.com TomEE treibt Tomitribe! Sent from my mobile device. Please excuse my brevity.
On May 22, 2014 8:10:59 PM CEST, Thiago Veronezi <[email protected]> wrote: >Hey guys, > >I had a quick chat with the build guys (#asftest) and it turns out I >just >need a build-admin to change the build steps for me. Who is our >build-admin? > >I would like to: >* change the 'check-formatting' step command to... mvn3 -U >checkstyle:check >-Pstyle >* add a new step called 'check-pmd' with... mvn3 -U pmd:check -Pstyle > >[]s, >Thiago. > > > > > >On Wed, May 21, 2014 at 11:54 AM, Thiago Veronezi ><[email protected]>wrote: > >> Yup, no new module for style. I guess we have the same goal. :) >> >> []s, >> Thiago. >> >> >> >> On Wed, May 21, 2014 at 11:49 AM, Romain Manni-Bucau < >> [email protected]> wrote: >> >>> the main point for me is don't add a module for style ;). >>> >>> >>> >>> Romain Manni-Bucau >>> Twitter: @rmannibucau >>> Blog: http://rmannibucau.wordpress.com/ >>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>> Github: https://github.com/rmannibucau >>> >>> >>> 2014-05-21 17:44 GMT+02:00 Thiago Veronezi <[email protected]>: >>> >>> > >>in container/openejb-core/pom.xml? >>> > >>> > Yup, currently we have it hooked in 'openejb-core/pom.xml' and in >>> 'pom.xml' >>> > ('style' profile). The existing 'style' profile is a dummy one. I >will >>> move >>> > what we have in 'openejb-core/pom.xml' to the profile definition >in the >>> > main pom. I would like to use the same profile to hook the pmd >also >>> defined >>> > by 'openejb-core/pom.xml'. The goal is to use the >'check-formatting' >>> step >>> > [Example: >>> > >>> > >>> >http://ci.apache.org/builders/tomee-trunk-ubuntu/builds/112/steps/check-formatting >>> > ] >>> > for both checkstyle and pmd. It would make the build to break >faster in >>> > case we have styling issues. >>> > >>> > >>BTW would be great to remove src/main/config/checkstyle.xml and >use >>> > new checktyle plugin inline feature (checkstyle.xml in ><configuration>) >>> > >>> > I prefer to have a separated configuration file for that. Anyway, >the >>> > current pmd checks already have a few custom configuration files. >>> > Checkstyle would follow the same path. >>> > >>> > []s, >>> > Thiago. >>> > >>> > >>> > On Wed, May 21, 2014 at 11:26 AM, Romain Manni-Bucau >>> > <[email protected]>wrote: >>> > >>> > > Hi Thiago, >>> > > >>> > > in container/openejb-core/pom.xml? >>> > > >>> > > BTW would be great to remove src/main/config/checkstyle.xml and >use >>> new >>> > > checktyle plugin inline feature (checkstyle.xml in ><configuration>) >>> > > >>> > > >>> > > >>> > > Romain Manni-Bucau >>> > > Twitter: @rmannibucau >>> > > Blog: http://rmannibucau.wordpress.com/ >>> > > LinkedIn: http://fr.linkedin.com/in/rmannibucau >>> > > Github: https://github.com/rmannibucau >>> > > >>> > > >>> > > 2014-05-21 17:24 GMT+02:00 Thiago Veronezi ><[email protected]>: >>> > > >>> > > > Hi guys, >>> > > > >>> > > > Where is the checkstyle trigger defined in our build? I would >like >>> to >>> > > move >>> > > > the existing openejb-core checkstyle and pmd checks to the >root >>> > module. I >>> > > > know how to do it for checkstyle, but I didnt find where we >call >>> 'mvn3 >>> > -U >>> > > > checkstyle:checkstyle -Pstyle', so I can do the same thing for >pmd. >>> > > > >>> > > > []s, >>> > > > Thiago. >>> > > > >>> > > >>> > >>> >> >>
