https://issues.apache.org/jira/browse/TOMEE-1221
above issue is created on JIRA and attached the patch. Please Review. My JIRA ID is kdchamil. On Fri, May 23, 2014 at 5:47 PM, Chamil Jeewantha <[email protected]>wrote: > Thanks, > > I will go ahead. > > > On Fri, May 23, 2014 at 5:35 PM, Romain Manni-Bucau <[email protected] > > wrote: > >> Well basically if you want to tackle it do the following steps: >> >> 1) checkout tomee (svn.apache.org/repos/asf/tomee/tomee/trunk/) >> 2) remove this block >> 3) svn diff > mypatch.patch >> 4) attach mypatch.patch to a jira on >> issues.apache.org/jira/browse/TOMEEgiving rights to Apache >> >> We'll apply it >> >> >> >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmannibucau.wordpress.com/ >> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> Github: https://github.com/rmannibucau >> >> >> 2014-05-23 14:01 GMT+02:00 Chamil Jeewantha <[email protected]>: >> >> > Thanks for your quick reply, >> > >> > I think it would be a good point for a newcomer to start contribution. >> If >> > someone can guide, I can fix that. >> > >> > Regards, >> > Chamil >> > >> > >> > On Fri, May 23, 2014 at 5:26 PM, Romain Manni-Bucau >> > <[email protected]>wrote: >> > >> > > Hi >> > > >> > > good catch. You are right...but this block should actually be removed >> ;) >> > > >> > > >> > > >> > > Romain Manni-Bucau >> > > Twitter: @rmannibucau >> > > Blog: http://rmannibucau.wordpress.com/ >> > > LinkedIn: http://fr.linkedin.com/in/rmannibucau >> > > Github: https://github.com/rmannibucau >> > > >> > > >> > > 2014-05-23 13:52 GMT+02:00 Chamil Jeewantha <[email protected]>: >> > > >> > > > I found the following code segment on init method of >> > > > TomcatWebAppBuilder.java >> > > > >> > > > if (standardContext.getConfigFile() == null) { >> > > > final String s = File.pathSeparator; >> > > > final File contextXmlFile = new >> > > > File(standardContext.getDocBase() + s + "META-INF" + s + >> > "context.xml"); >> > > > if (contextXmlFile.exists()) { >> > > > BackportUtil.getAPI().setConfigFile(standardContext, >> > > > contextXmlFile); >> > > > standardContext.setOverride(true); >> > > > } >> > > > } >> > > > >> > > > I wonder why the File.pathSeparator is used instead of >> File.separator. >> > Is >> > > > this purposefully done? If so what is the reason? >> > > > >> > > > >> > > > Thanks in Advance! Sorry if this is a mad question. >> > > > -- >> > > > [email protected] >> > > > >> > > >> > >> > >> > >> > -- >> > [email protected] >> > >> > > > > -- > [email protected] > -- [email protected]
