+1 Me too. Having TomEE look like Tomcat drives home the usp that TomEE is "just plain Tomcat" with Java EE added.
-- Bjorn Danielsson Cuspy Code AB Andy Gumbrecht <[email protected]> wrote: > +1 > On 25/07/2014 13:34, Romain Manni-Bucau wrote: >> Well issue is less important than it since it only affects console logger >> (not file loggers AFAIK). But having tomee looking like tomcat is surely >> better than diverging. Makes more obvious what we work for @tomee + makes >> tomcat dev environment more convenient. >> >> Here is our default formatter on tomee side >> http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-juli/src/main/java/org/apache/tomee/jul/formatter/SimpleTomEEFormatter.java >> (instead of OneLineFormatter of tomcat) >> >> >> >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmannibucau.wordpress.com/ >> LinkedIn: http://fr.linkedin.com/in/rmannibucau >> Github: https://github.com/rmannibucau >> >> >> 2014-07-25 13:10 GMT+02:00 Chamil Jeewantha <[email protected]>: >> >>> If I am using Tomcat and I integrate TomEE using tomee war, I may suddenly >>> notice there is a difference in logging if TomEE follows some other logging >>> pattern than Tomcat. So aligning the TomEE default pattern with Tomcat is >>> good in the sense of User Experience. >>> >>> Nobody goes in to production with the default settings of a server. That >>> statement is valid for the logging properties as well. So focusing on >>> developer friendly default configuration seems the better option for me. >>> >>> As a developer, I used to search through the log by the class name most of >>> the times. So I see the class name as important info in my default logging. >>> >>> Thanks! >>> >>> >>> On Fri, Jul 25, 2014 at 4:07 PM, Tommy Tynjä <[email protected]> wrote: >>> >>>> Would definitely be worth providing a sensible default logging pattern in >>>> TomEE. Alignment is important for readability so we should address that. >>>> >>>> Why would it be a problem to divert from the Tomcat default logging in >>>> TomEE? Most users are likely to define their own log patterns anyway. >>>> >>>> BR, >>>> Tommy Tynjä >>>> >>>> >>>> On Thu, Jul 24, 2014 at 3:39 PM, Romain Manni-Bucau < >>> [email protected] >>>> wrote: >>>> >>>>> Hmm, fun I exactly think the opposite: in dev you want stacktraces more >>>> or >>>>> less but in prod you need details to investigate as fast as possible. >>> You >>>>> don't care about perf since you only log error and maybe warn but >>> nothing >>>>> else. >>>>> >>>>> That said main issue is doing it differently from tomcat. >>>>> >>>>> I'll try to ping tomcat@ tonight to see why they changed and if we can >>>>> enhance it together. >>>>> >>>>> >>>>> >>>>> >>>>> Romain Manni-Bucau >>>>> Twitter: @rmannibucau >>>>> Blog: http://rmannibucau.wordpress.com/ >>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>> Github: https://github.com/rmannibucau >>>>> >>>>> >>>>> 2014-07-24 15:18 GMT+02:00 Andy Gumbrecht <[email protected]>: >>>>> >>>>>> Not necessarily, I think we should pick a simple and fast format as >>> the >>>>>> default, something like [dd:HH:mm:ss][LEVEL] - Message. >>>>>> Having thread names and class names is a huge overhead usually - They >>>>>> should be dev options. >>>>>> >>>>>> Andy. >>>>>> >>>>>> >>>>>> On 24/07/2014 07:23, Romain Manni-Bucau wrote: >>>>>> >>>>>>> Sure >>>>>>> >>>>>>> Question is not technical but "do we stay aligned on tomcat" >>>>>>> >>>>>>> One trade off can be to trim some parts to align column stayimg one >>>> line >>>>>>> logs i think >>>>>>> Le 23 juil. 2014 23:31, "[email protected]" < >>>>>>> [email protected]> a écrit : >>>>>>> >>>>>>> Looks bad. We should be able to define a pattern ? >>>>>>>> Sent from my HTC >>>>>>>> >>>>>>>> ----- Reply message ----- >>>>>>>> From: "Romain Manni-Bucau" <[email protected]> >>>>>>>> To: "[email protected]" <[email protected]> >>>>>>>> Subject: new tomcat logs >>>>>>>> Date: Thu, Jul 24, 2014 00:07 >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> new tomcat logs look like: >>>>>>>> https://gist.github.com/rmannibucau/989a38620aec394bd45d >>>>>>>> >>>>>>>> do we keep it as default? Then most of our logs are no more >>> readable >>>> :( >>>>>>>> >>>>>>>> Romain Manni-Bucau >>>>>>>> Twitter: @rmannibucau >>>>>>>> Blog: http://rmannibucau.wordpress.com/ >>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau >>>>>>>> Github: https://github.com/rmannibucau >>>>>>>> >>>>>> -- >>>>>> Andy Gumbrecht >>>>>> >>>>>> http://www.tomitribe.com >>>>>> [email protected] >>>>>> https://twitter.com/AndyGeeDe >>>>>> >>>>>> TomEE treibt Tomitribe! | http://tomee.apache.org >>>>>> >>>>>>
