Can anyone confirm please?
Chris Christo
{ github.com/christchristo }
On 18 Sep 2014, at 15:18, Chris Christo <[email protected]> wrote:
> On that note, will my pull request be ignored for now? Shall I re submit with
> a linked JIRA?
>
> On 28 Aug 2014, at 15:42, Andy Gumbrecht <[email protected]> wrote:
>
>> Until we are actually a Git based project
>> (https://git-wip-us.apache.org/repos/asf) rather than an SVN one we'll have
>> issues.
>>
>> At the moment it's a Git mirror of SVN, which makes working with it
>> 'unusual'. Not something we should promote, especially if we are about to
>> change to Git.
>>
>> Any changes 'should' have a JIRA - Doesn't always happen, but it is good
>> practice - Would actually be nice to be able to enforce this.
>>
>> The best way to get noticed is still to create a JIRA and attach a patch -
>> This forces the submitter to accept the Apache Software Foundation
>> contributor license (which I don't see with Git currently).
>>
>> We shouldn't apply pull requests without knowing if the contributor has
>> acknowledged the ASF license.
>>
>> Andy.
>>
>> On 27/08/2014 17:30, Thiago Veronezi wrote:
>>> Yeah... It looks like the github notifications need to be approved to be
>>> published in the dev list.
>>>
>>> []s,
>>> Thiago.
>>>
>>>
>>> On Wed, Aug 27, 2014 at 11:26 AM, Romain Manni-Bucau <[email protected]>
>>> wrote:
>>>
>>>> just got the notification. Well not linking it to a jira means it will
>>>> not be linked to a release AFAIK
>>>>
>>>>
>>>> Romain Manni-Bucau
>>>> Twitter: @rmannibucau
>>>> Blog: http://rmannibucau.wordpress.com/
>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>> Github: https://github.com/rmannibucau
>>>>
>>>>
>>>> 2014-08-27 17:21 GMT+02:00 Chris Christo <[email protected]>:
>>>>> Why do I need a JIRA name in the commit message? Is that the guidelines
>>>> you guys require for every commit? I imagine the owners of the github repo
>>>> would be watching it, and thus would receive notifications.
>>>>>
>>>>> Chris Christo
>>>>> { twitter.com/christokios }
>>>>> { github.com/christokios }
>>>>>
>>>>> On 27 Aug 2014, at 23:16, Thiago Veronezi <[email protected]> wrote:
>>>>>
>>>>>> Ah! I just saw it. It was filtered by my email client!
>>>>>>
>>>>>> []s,
>>>>>> Thiago.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Aug 27, 2014 at 11:09 AM, Romain Manni-Bucau <
>>>> [email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> * link = put jira name in the commit message
>>>>>>>
>>>>>>>
>>>>>>> Romain Manni-Bucau
>>>>>>> Twitter: @rmannibucau
>>>>>>> Blog: http://rmannibucau.wordpress.com/
>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>>> Github: https://github.com/rmannibucau
>>>>>>>
>>>>>>>
>>>>>>> 2014-08-27 17:09 GMT+02:00 Romain Manni-Bucau <[email protected]>:
>>>>>>>> did you linked it to a jira? otherwise I think we don't have any
>>>>>>> notification
>>>>>>>>
>>>>>>>> Romain Manni-Bucau
>>>>>>>> Twitter: @rmannibucau
>>>>>>>> Blog: http://rmannibucau.wordpress.com/
>>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>>>> Github: https://github.com/rmannibucau
>>>>>>>>
>>>>>>>>
>>>>>>>> 2014-08-27 17:06 GMT+02:00 helio frota <[email protected]>:
>>>>>>>>>> Its only a readme, but was testing the waters to see if anyone is
>>>>>>>>> actively handling pull requests, before I submit something > more
>>>>>>>>> substantial.
>>>>>>>>>
>>>>>>>>> Chris Christo +1
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Aug 27, 2014 at 11:22 AM, Chris Christo <[email protected]>
>>>> wrote:
>>>>>>>>>> I submitted a pull request, just wondering if anyone will pick this
>>>> up?
>>>>>>>>>> Its only a readme, but was testing the waters to see if anyone is
>>>>>>> actively
>>>>>>>>>> handling pull requests, before I submit something more substantial.
>>>>>>>>>>
>>>>>>>>>> Chris Christo
>>>>>>>>>> { twitter.com/christokios }
>>>>>>>>>> { github.com/christokios }
>>>>>>>>>>
>>>>>>>>>> On 25 Aug 2014, at 20:06, Romain Manni-Bucau <[email protected]
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> cause our main repo is not github and nobody was using github so
>>>>>>>>>>> README.adoc was not that useful ;)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Romain Manni-Bucau
>>>>>>>>>>> Twitter: @rmannibucau
>>>>>>>>>>> Blog: http://rmannibucau.wordpress.com/
>>>>>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>>>>>>> Github: https://github.com/rmannibucau
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 2014-08-25 13:55 GMT+02:00 Chris Christo <[email protected]>:
>>>>>>>>>>>> Cool! Any reason why there’s no README.md at root? Can I add one
>>>> (at
>>>>>>>>>> least just to assure pull requests are all good)?
>>>>>>>>>>>>
>>>>>>>>>>>> Chris Christo
>>>>>>>>>>>> { twitter.com/christokios }
>>>>>>>>>>>> { github.com/christokios }
>>>>>>>>>>>>
>>>>>>>>>>>> On 25 Aug 2014, at 19:52, Romain Manni-Bucau <
>>>> [email protected]
>>>>>>>>>> wrote:
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> it should be wired now
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Romain Manni-Bucau
>>>>>>>>>>>>> Twitter: @rmannibucau
>>>>>>>>>>>>> Blog: http://rmannibucau.wordpress.com/
>>>>>>>>>>>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>>>>>>>>> Github: https://github.com/rmannibucau
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> 2014-08-25 13:48 GMT+02:00 Chris Christo <[email protected]>:
>>>>>>>>>>>>>> Hey, you guys accept pull requests at
>>>>>>> https://github.com/apache/tomee
>>>>>>>>>> ?
>>>>>>>>>>>>>> Chris Christo
>>>>>>>>>>>>>> { twitter.com/christokios }
>>>>>>>>>>>>>> { github.com/christokios }
>>>>>>>>>>>>>>
>>>>>>>>>>
>>
>
