2014-10-27 13:03 GMT+01:00 Mark Struberg <[email protected]>: > In all the scenarios I know this works by NOT working on the upstream repo at > all. > Instead this commit gets performed on some other repo and a pull request is > issued. The pull request triggers a merge in a auto-generated temporary > throw-away branch (integration branch) and if it passes it can get pulled in > by some maintainer. > > This is fine, but fundamentally different to what we do/have at ASF in > general. > > The problem with the tests is something different. WAY too many tests are > just broken in lots of situations. E.g. they are depending on the order in > which they get executed (which might be different depending on OS and JDK > version), do not work if you have a proxy configured, don't work if you have > a firewall, etc >
Something for another thread I guess. Personally I think integration profiles are useless and actually we don't have a single "envrt dependent" test which can 't pass by default so just a matter of time. > We really must fix the random ones and move all those infrastructure specific > tests to an integration-test profile. > After this is done a lot less people will have problems to build TomEE > themselves. > > > LieGrue, > strub > > > > >> On Monday, 27 October 2014, 11:40, Marius Kruger <[email protected]> wrote: >> > Hi, >> one way I think working on the develop branch could be very useful is if we >> can have a bot that runs the test-suite after every commit and only pushes >> commits to master if all the tests pass, and notify the committer if it >> doesn't. >> This would also alleviate developer/casual contributor frustrations in >> getting a 'clean' tree to start working on (like what Daniel is >> experiencing). >> >> -- >> my2c >> ✝ Marius >>
