I feel bad, because it seems like I always bring these issues up. However, I'm inclined to agree with Romain. I personally couldn't +1 a release with a known issue in the licence/notice files. At the moment, I'm not 100% sure these are an issue, hence why I'm asking. I think we should answer these for sure, and if we're 100% sure we're good, then we can push on.
Jon On Tue, Dec 1, 2015 at 1:35 PM, Romain Manni-Bucau <[email protected]> wrote: > Asm code needs to ow2 mention AFAIK. Release with broken licensing is > tolerated for incubator if immediately fixed but not sure for TLP. I > wouldnt do it but if too hard to roll a m2 with the fix we can probably go > this way exceptionnally. > Le 1 déc. 2015 14:18, "Andy" <[email protected]> a écrit : > > > xbean-asm-shaded is dual licensed with an Apache 2.0 license, but I also > > find the following references to the ASM license: > > > > \assembly\openejb-standalone\src\main\resources\LICENSE > > \examples\LICENSE > > \itests\openejb-itests-app\src\main\application\META-INF\LICENSE > > \tomee\apache-tomee\src\main\resources\META-INF\LICENSE > > \tomee\tomee-plume-webapp\src\main\resources\META-INF\LICENSE > > \tomee\tomee-plus-webapp\src\main\resources\META-INF\LICENSE > > \tomee\tomee-webapp\src\main\resources\META-INF\LICENSE > > \utils\openejb-provisionning\src\main\legal\LICENSE > > > > Joda time is Apache 2.0: http://joda-time.sourceforge.net/license.html - > > We are not shipping a 'Derivative Work' so the NOTICE mention is not > > 'required', just courteous. We'll add it to the next release. > > > > Not sure what you mean with java-support OWasp? > > > > Andy. > > > > On 01/12/2015 11:52, Jonathan Gallimore wrote: > > > >> I think it probably can. > >> > >> That said, I have the following queries with the LICENCE/NOTICE files: > >> > >> 1. ASM notice from xbean-asm-shaded looks like its missing > >> 2. Joda time notice looks like its missing > >> 3. Notice for java-support jar (reference to OWasp) looks like its > >> missing. > >> > >> I'd be grateful if someone else could double check. > >> > >> Thanks > >> > >> Jon > >> > >> On Tue, Dec 1, 2015 at 10:43 AM, Jean-Louis Monteiro < > >> [email protected]> wrote: > >> > >> Can we close the vote now? > >>> It's been opened for more than 10 days now. > >>> > >>> > >>> > >>> -- > >>> Jean-Louis Monteiro > >>> http://twitter.com/jlouismonteiro > >>> http://www.tomitribe.com > >>> > >>> On Wed, Nov 25, 2015 at 2:19 PM, Jean-Louis Monteiro < > >>> [email protected]> wrote: > >>> > >>> Here is my +1 Andy > >>>> > >>>> Thank you very much for your patience and hard work > >>>> > >>>> -- > >>>> Jean-Louis Monteiro > >>>> http://twitter.com/jlouismonteiro > >>>> http://www.tomitribe.com > >>>> > >>>> On Mon, Nov 23, 2015 at 5:25 PM, Jonathan Gallimore < > >>>> [email protected]> wrote: > >>>> > >>>> Ditto. (I'll review tonight, not I have no patience) :-) > >>>>> > >>>>> Jon > >>>>> > >>>>> On Mon, Nov 23, 2015 at 4:21 PM, Andy Gumbrecht < > >>>>> > >>>> [email protected] > >>> > >>>> wrote: > >>>>> > >>>>> I have none, can you not tell I am about to explode? :-D > >>>>>> > >>>>>> On 23 November 2015 at 17:15, Jean-Louis Monteiro < > >>>>>> [email protected]> > >>>>>> wrote: > >>>>>> > >>>>>> Same here. Built it and ran a couple of time, but still need the > >>>>>>> > >>>>>> legal > >>> > >>>> stuff. > >>>>>>> Thanks Andy for you patience. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> Jean-Louis Monteiro > >>>>>>> http://twitter.com/jlouismonteiro > >>>>>>> http://www.tomitribe.com > >>>>>>> > >>>>>>> On Mon, Nov 23, 2015 at 4:39 PM, Mark Struberg <[email protected]> > >>>>>>> > >>>>>> wrote: > >>>>>> > >>>>>>> Looks good so far. > >>>>>>>> Trying to review it in depth this evening. > >>>>>>>> > >>>>>>>> LieGrue, > >>>>>>>> strub > >>>>>>>> > >>>>>>>> > >>>>>>>> Am 23.11.2015 um 15:43 schrieb Romain Manni-Bucau < > >>>>>>>>> > >>>>>>>> [email protected] > >>>>>>> > >>>>>>>> : > >>>>>>>>> > >>>>>>>>> +1, thanks Andy for the hard work! > >>>>>>>>> > >>>>>>>>> side note: we should say we have some deps the main project > >>>>>>>>> > >>>>>>>> doesn't > >>>>> > >>>>>> build > >>>>>>> > >>>>>>>> in tags when it is the case (javaee-api, jcs here), thought to > >>>>>>>>> > >>>>>>>> the > >>> > >>>> vote > >>>>>> > >>>>>>> mail but then thought maybe in main README it would be better. > >>>>>>>>> > >>>>>>>> Just a > >>>>> > >>>>>> side > >>>>>>>> > >>>>>>>>> note before forgetting :). > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Romain Manni-Bucau > >>>>>>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>>>>>>>> <http://rmannibucau.wordpress.com> | Github < > >>>>>>>>> > >>>>>>>> https://github.com/rmannibucau> | > >>>>>>>> > >>>>>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > >>>>>>>>> <http://www.tomitribe.com> > >>>>>>>>> > >>>>>>>>> 2015-11-20 17:06 GMT+01:00 Alex Soto <[email protected]>: > >>>>>>>>> > >>>>>>>>> Do you need any kind of help on this in terms of downloading > >>>>>>>>>> > >>>>>>>>> something > >>>>>> > >>>>>>> in > >>>>>>>> > >>>>>>>>> clean environment and inspect something? > >>>>>>>>>> > >>>>>>>>>> El dv., 20 nov. 2015 a les 16:56, Romain Manni-Bucau (< > >>>>>>>>>> [email protected]>) > >>>>>>>>>> va escriure: > >>>>>>>>>> > >>>>>>>>>> Hmm > >>>>>>>>>>> > >>>>>>>>>>> Maybe check we dont have git info in mvn artifacts otherwise > >>>>>>>>>>> > >>>>>>>>>> binaries > >>>>>> > >>>>>>> would > >>>>>>>>>> > >>>>>>>>>>> be wrong then. Anyone recalls? > >>>>>>>>>>> Le 20 nov. 2015 07:55, "Andy Gumbrecht" < > >>>>>>>>>>> > >>>>>>>>>> [email protected]> > >>>>> > >>>>>> a > >>>>>> > >>>>>>> écrit : > >>>>>>>>>>> > >>>>>>>>>>> Me too. so no idea where it's gone? - I'm going to delete it > >>>>>>>>>>>> > >>>>>>>>>>> and > >>>>> > >>>>>> take > >>>>>>> > >>>>>>>> it > >>>>>>>>>> > >>>>>>>>>>> from the tomee-7.0.0-M1 branch again > >>>>>>>>>>>> > >>>>>>>>>>>> -- > >>>>>>>>>>>> Andy Gumbrecht > >>>>>>>>>>>> https://twitter.com/AndyGeeDe > >>>>>>>>>>>> http://www.tomitribe.com > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>> > >>>>>> > >>>>>> -- > >>>>>> Andy Gumbrecht > >>>>>> https://twitter.com/AndyGeeDe > >>>>>> http://www.tomitribe.com > >>>>>> > >>>>>> > >>>>> > >>>>> -- > >>>>> Jonathan Gallimore > >>>>> http://twitter.com/jongallimore > >>>>> http://www.tomitribe.com > >>>>> > >>>>> > >>>> > >> > >> > > -- > > Andy Gumbrecht > > https://twitter.com/AndyGeeDe > > > > > -- Jonathan Gallimore http://twitter.com/jongallimore http://www.tomitribe.com
