Permissions shouldn't be needed, just fork the repository on GitHub and send a PR there. We'll be happy to review and merge.
Jon On Fri, Sep 21, 2018 at 1:17 PM Alex The Rocker <[email protected]> wrote: > Hi Romain, > > I created a JIRA to track this dependency upgrade : TOMEE-2241 > (https://issues.apache.org/jira/browse/TOMEE-2241). > > Doing the PR myself would be fun but I guess I first need to have some > contributor permissions, isn't it? > > Regarding your idea to modify conf/system.properties, is that really > clean? can't we have commons-lang3-3.6.jar delivered in a web app used > by struts.jar delivered in same web app by default? > > Thanks, > Alexandre > > Le ven. 21 sept. 2018 à 10:13, Romain Manni-Bucau > <[email protected]> a écrit : > > > > Hi Alex > > > > > > > > Le ven. 21 sept. 2018 à 09:56, Alex The Rocker <[email protected]> a > > écrit : > > > > > Hello TomEE developpers, > > > > > > We are running our web apps with TomEE+ 7.0.5 and we are trying to > > > upgrade our Apache struts based app to latest version (Struts 2.5.17). > > > > > > However it turns out that Structs 2.5.17 depends on new classes > > > introduced in commons-lang3-3.6 (class > > > org.apache.commons.lang3.reflect.MethodUtils does not have a method > > > getAnnotation method which is expected by struts 2.5.17). > > > > > > Questions: > > > 1) Would it be possible to upgrade Apache TomEE+ 7.0.6 and higher > > > (7.1/ 8.x branches) dependency on commons-lang3 from 3.5 to latest > > > (3.8) ? > > > > > > > Sure, want to do the PR? > > > > > > > > > > 2) What would be the cleanest solution for people running already > > > frozen TomEE versions for upgrading their web app to Struts 2.5.17? > > > (ideally, something fully packaged inside the .WAR would be best, if > > > possible) > > > > > > > Did you try to add in conf/system.properties: > > > > openejb.classloader.forced-load=org.apache.commons.lang3 > > > > ? > > > > > > > > > > Thanks > > > Alex. > > > >
