Hi folks!
Frankie, I left a comment on this at a different email thread named:
"Re: How to find out that someone else is already working on a task".
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 10/12/18 10:29, Jonathan Gallimore wrote:
This looks great! Are you going to create a page on the site for it? Let us
know if you need any help.
Cheers
Jon
On Sat, Dec 8, 2018 at 3:48 PM Frankie <[email protected]> wrote:
I started to work on the documentation of the workflow as discussed in
http://tomee-openejb.979440.n4.nabble.com/How-to-find-out-that-someone-else-is-already-working-on-a-task-td4685855.html
.
As a result of the discussion in
http://tomee-openejb.979440.n4.nabble.com/Stabilize-TomEE-Build-td4685909.html
I think it would be nice to detect (and fix) potential build problems
before
a PR is created so I decided to include this under "Submit change" and
dropped the step "Monitor build" ...
So this would be the workflow as a compact overview - for most of the
single
steps I plan to link to additional information in detail - comments are
welcome:
1. Check JIRA
* create ticket, if not already existing
* if ticket already assigned to someone else => stop & talk
* assign ticket to contributor, if not already assigned
(ask on mailing list, if no permission to assign)
2. Process Task
* fork repository
* create branch in own repository (name = JIRA ticket number …)
* discuss on mailing list
* work on code
* document work in JIRA ticket
3. Submit Change
* ensure code compiles
* ensure tests passes
* create PR (pull request)
* ask for review on mailing list
4. Merge Change (done by a committer)
* review changes
* merge code
* change JIRA ticket status / close ticket
5. Clean up
* wait until PR is merged (ticket status change)
* remove branch in own repository
--
Sent from:
http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
