Thank you, Bruno. I just repost your comment here:

Hi Frankie,

I suggest a middle step between 3. and 4. related to PR review:

Review PR

* Checkout master: `git checkout master`

* Update master: `git fetch upstream` and `git rebase upstream/master`

* Create a local review branch: `git checkout -b review-prXXX`

* Switch to review branch: `checkout review-prXXX`

* Checkout PR: `git fetch upstream pull/XXX/head:prXXX`

* Merge PR into review branch: `git merge prXXX`

* Most times you don't need to build the whole project. It depends on 
what code is being added/changed. If it's and example, go to the 
sub-project and do a `mvn clean install` there.

* If it's an example, check the guidelines for compliance: 
https://github.com/apache/tomee/blob/master/examples/README.adoc


I think we could place Frankie's guidelines as a file in the project, as 
a PR. What do you guys think?

Cheers

Bruno Baptista
https://twitter.com/brunobat_





--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Reply via email to