Github user josehenriqueventura commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/263#discussion_r240049155
  
    --- Diff: examples/mp-metrics-histogram/pom.xml ---
    @@ -0,0 +1,87 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +
    +    Licensed to the Apache Software Foundation (ASF) under one or more
    +    contributor license agreements.  See the NOTICE file distributed with
    +    this work for additional information regarding copyright ownership.
    +    The ASF licenses this file to You under the Apache License, Version 2.0
    +    (the "License"); you may not use this file except in compliance with
    +    the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing, software
    +    distributed under the License is distributed on an "AS IS" BASIS,
    +    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +    See the License for the specific language governing permissions and
    +    limitations under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <parent>
    +        <artifactId>examples</artifactId>
    +        <groupId>org.apache.tomee</groupId>
    +        <version>8.0.0-SNAPSHOT</version>
    +    </parent>
    --- End diff --
    
    A few days ago, @brunobat alerted (Example maven parent email) us about the 
use of <parent> tag which refers to the parent pom "examples/pom.xml" that will 
add loads of unnecessary libraries to the war generated and which increases the 
disk usage.
    
    with <parent> tag mp-metrics-histogram-8.0.0-SNAPSHOT.war - 7.3mb
    without <parent> tag mp-metrics-histogram-8.0.0-SNAPSHOT.war - 4.1kB
    
    This PR shows what can be done to solve the issue described below 
https://github.com/apache/tomee/pull/260


---

Reply via email to