Github user josehenriqueventura commented on a diff in the pull request:
https://github.com/apache/tomee/pull/263#discussion_r240049166
--- Diff:
examples/mp-metrics-histogram/src/main/java/org/superbiz/histogram/WeatherService.java
---
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p/>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p/>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.superbiz.histogram;
+
+import org.eclipse.microprofile.metrics.Histogram;
+import org.eclipse.microprofile.metrics.Metadata;
+import org.eclipse.microprofile.metrics.MetricRegistry;
+import org.eclipse.microprofile.metrics.MetricType;
+import org.eclipse.microprofile.metrics.annotation.Metric;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+@Path("/weather")
+@Produces(MediaType.APPLICATION_JSON)
+@Consumes(MediaType.APPLICATION_JSON)
+@ApplicationScoped
+public class WeatherService {
+
+ @Inject
+ private MetricRegistry registry;
+
+ @Inject
+ @Metric(name = "temperatures", description = "A histogram metrics
example.",
+ displayName = "Histogram of Recent New York Temperatures")
+ private Histogram histogram;
+
+ @Path("/histogram")
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ public Histogram getTemperatures() {
+ Metadata metadata = new Metadata("temperatures",
MetricType.HISTOGRAM, "degrees F");
+ metadata.setDescription("A histogram of recent New York
temperatures.");
+ final int[] RECENT_NEW_YORK_TEMPS = { 46, 45, 50, 46, 45, 27, 30,
48, 55, 54, 45, 41, 45, 43, 46 };
--- End diff --
RECENT_NEW_YORK_TEMPS seems to be a convention of a constant variable. I
suggest you move it out of the method and add private along with static to
match the java convention.
---
