Hi Gurkan, You right! My fault from my last two Pull Request. I'll work to it not happenings again.
Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <[email protected]> escreveu: > Hi > As a general idea: > I advise to attach a JIRA issue for each commit. Otherwise, the community > are not able to follow the commits and their exact reasons. > Regards. > Gurkan > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[email protected]> > wrote: > > > Thanks for review it and merge Jon. > > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <[email protected]> > > escreveu: > > > > > I'll keep my eyes on the buildbot. :) > > > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore < > > > [email protected]> escreveu: > > > > > >> Merged - thanks for sending that over! > > >> > > >> Jon > > >> > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[email protected]> > > >> wrote: > > >> > > >> > Hi folks, > > >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch: > > >> > https://github.com/apache/tomee/pull/450 > > >> > Please review it. > > >> > > > >> > That is the current status for that branch: > > >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png] > > >> > > > >> > > > >> > -- > > >> > Daniel "soro" Cunha > > >> > https://twitter.com/dvlc_ > > >> > > > >> > > > >> > > > > > > > > > -- > > > Daniel "soro" Cunha > > > https://twitter.com/dvlc_ > > > > > > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
