Thank you Jon! :) Em dom, 24 de mar de 2019 às 11:07, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu:
> Changes pushed and its building: > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/48 > > On Sun, Mar 24, 2019 at 9:46 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > These ring a bell. I think I have a fix for them - I'll check. > > > > Jon > > > > On Sat, Mar 23, 2019 at 2:11 PM Daniel Cunha <daniels...@apache.org> > > wrote: > > > >> Bit stuck with those tests: > >> > >> Failed tests: > >> ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected > >> [500] > >> but found [200] > >> SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but > >> found [200] > >> > >> For some reason I can't debug it. That is the two tests is failing on > >> MicroProfile JWT TCK for TomEE 7.1.x. > >> (I'm asking for help) > >> > >> > >> Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <daniels...@apache.org > > > >> escreveu: > >> > >> > Well, > >> > > >> > Seems that we still have a module with test failing! > >> > Investigating what is it. It build well yesterday here. :) > >> > > >> > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47 > >> > [ERROR] Please refer to > >> > > >> > /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports > >> > for the individual test results. > >> > > >> > Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu < > cgerdo...@gmail.com > >> > > >> > escreveu: > >> > > >> >> Cool, thank you! > >> >> > >> >> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <daniels...@apache.org> > >> >> wrote: > >> >> > >> >> > Hi Gurkan, > >> >> > > >> >> > You right! My fault from my last two Pull Request. > >> >> > I'll work to it not happenings again. > >> >> > > >> >> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu < > >> cgerdo...@gmail.com > >> >> > > >> >> > escreveu: > >> >> > > >> >> > > Hi > >> >> > > As a general idea: > >> >> > > I advise to attach a JIRA issue for each commit. Otherwise, the > >> >> community > >> >> > > are not able to follow the commits and their exact reasons. > >> >> > > Regards. > >> >> > > Gurkan > >> >> > > > >> >> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha < > >> daniels...@apache.org> > >> >> > > wrote: > >> >> > > > >> >> > > > Thanks for review it and merge Jon. > >> >> > > > > >> >> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha < > >> >> > daniels...@apache.org> > >> >> > > > escreveu: > >> >> > > > > >> >> > > > > I'll keep my eyes on the buildbot. :) > >> >> > > > > > >> >> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore < > >> >> > > > > jonathan.gallim...@gmail.com> escreveu: > >> >> > > > > > >> >> > > > >> Merged - thanks for sending that over! > >> >> > > > >> > >> >> > > > >> Jon > >> >> > > > >> > >> >> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha < > >> >> > daniels...@apache.org> > >> >> > > > >> wrote: > >> >> > > > >> > >> >> > > > >> > Hi folks, > >> >> > > > >> > > >> >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch: > >> >> > > > >> > https://github.com/apache/tomee/pull/450 > >> >> > > > >> > Please review it. > >> >> > > > >> > > >> >> > > > >> > That is the current status for that branch: > >> >> > > > >> > > >> >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png] > >> >> > > > >> > > >> >> > > > >> > > >> >> > > > >> > -- > >> >> > > > >> > Daniel "soro" Cunha > >> >> > > > >> > https://twitter.com/dvlc_ > >> >> > > > >> > > >> >> > > > >> > > >> >> > > > >> > >> >> > > > > > >> >> > > > > > >> >> > > > > -- > >> >> > > > > Daniel "soro" Cunha > >> >> > > > > https://twitter.com/dvlc_ > >> >> > > > > > >> >> > > > > >> >> > > > > >> >> > > > -- > >> >> > > > Daniel "soro" Cunha > >> >> > > > https://twitter.com/dvlc_ > >> >> > > > > >> >> > > > >> >> > > >> >> > > >> >> > -- > >> >> > Daniel "soro" Cunha > >> >> > https://twitter.com/dvlc_ > >> >> > > >> >> > >> > > >> > > >> > -- > >> > Daniel "soro" Cunha > >> > https://twitter.com/dvlc_ > >> > > >> > >> > >> -- > >> Daniel "soro" Cunha > >> https://twitter.com/dvlc_ > >> > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
