Here is what I can see on master for example *find . -name pom.xml |xargs grep '<parent>'*
*./polling-parent/polling-domain/pom.xml: <parent>./polling-parent/polling-client/pom.xml: <parent>./polling-parent/polling-web/pom.xml: <parent>./polling-parent/polling-mdb/pom.xml: <parent>./polling-parent/polling-core/pom.xml: <parent>./connector-ear/connector-sample-ear/pom.xml: <parent>./connector-ear/connector-sample-api/pom.xml: <parent>./connector-ear/connector-sample-war/pom.xml: <parent>./connector-ear/connector-sample-functional-tests/pom.xml: <parent>./connector-ear/connector-sample-impl/pom.xml: <parent>./connector-ear/connector-sample-rar/pom.xml: <parent>./pom.xml: <parent>./quartz-app/quartz-beans/pom.xml: <parent>./quartz-app/quartz-ra/pom.xml: <parent>./resources-jmx-example/resources-jmx-ear/pom.xml: <parent>./resources-jmx-example/resources-jmx-ejb/pom.xml: <parent>* *./mp-opentracing-traced/pom.xml: <parent>*./simple-ear/moviefun-webapp/pom.xml: <parent> ./simple-ear/moviefun-business-model/pom.xml: <parent> ./simple-ear/moviefun-ear/pom.xml: <parent> ./simple-ear/moviefun-functional-tests/pom.xml: <parent> ./simple-ear/moviefun-business-logic/pom.xml: <parent> ./ear-testing/business-model/pom.xml: <parent> ./ear-testing/business-logic/pom.xml: <parent> *./mp-metrics-metered/pom.xml: <parent>* ./bval-evaluation-redeployment/WebApp1/pom.xml: <parent> ./bval-evaluation-redeployment/runner/pom.xml: <parent> ./bval-evaluation-redeployment/WebApp2/pom.xml: <parent> So far I can see 2 which are referencing a parent where they should not. The other are multi-module samples so as soon as the aggregator does not reference a parent, it's fine for sub-modules to do so -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, May 27, 2019 at 7:15 PM David Salter <[email protected]> wrote: > Hi Jean-Louis, > > I’m a fan of the simple samples and this is one of the things I love about > TomEE. > > Do you have more details on which samples aren’t self contained? I’d be > happy to help do some refactoring to make them easier to understand. > > Thanks > > David. > > On Mon, 27 May 2019 at 14:24, Jean-Louis Monteiro < > [email protected]> > wrote: > > > Hi, > > > > I started contributing a long time ago to TomEE. What made me get into > Java > > EE and TomEE was the examples. > > > > They were simple, easy to run and self contained. > > > > Looks like on the last part, we haven't done a good job. > > Or did we decided to relax the "self contained" part and now have > examples > > depending on the TomEE reactor and build? > > > > I am currently fixing an microprofile example and realized that we were > > breaking this rule. > > > > Any feedback is appreciated so I can fix the other examples too. > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > >
