Thanks Jonathan :)

I’ve submitted a PR at: https://github.com/apache/tomee/pull/477 
<https://github.com/apache/tomee/pull/477>

Let me know if it needs any changes.

Thanks.

David.

> On 31 May 2019, at 16:48, Jonathan Gallimore <[email protected]> 
> wrote:
> 
> Done, thanks David!
> 
> On Fri, May 31, 2019 at 4:46 PM David Salter <[email protected]>
> wrote:
> 
>> Hi,
>> 
>> I’ve created a JIRA for the parent pom in the  mp-opentracing-traced
>> project.
>> 
>> https://issues.apache.org/jira/browse/TOMEE-2537 <
>> https://issues.apache.org/jira/browse/TOMEE-2537>
>> 
>> Can someone assign this to me and I’ll get the PR submitted.
>> 
>> Thanks.
>> 
>> David.
>> 
>>> On 27 May 2019, at 19:18, David Blevins <[email protected]> wrote:
>>> 
>>> Good catch.  We definitely haven't changed the philosophy on examples.
>> They all need to be fixed.
>>> 
>>> 
>>>> On May 27, 2019, at 10:20 AM, Jean-Louis Monteiro <
>> [email protected]> wrote:
>>>> 
>>>> Here is what I can see on master for example
>>>> 
>>>> *find . -name pom.xml |xargs grep '<parent>'*
>>> 
>>> Here's another way to try that
>>> 
>>> $ grep "<parent>" examples/*/pom.xml
>>> examples/mp-metrics-gauge/pom.xml:    <parent>
>>> examples/mp-metrics-metered/pom.xml:  <parent>
>>> examples/mp-opentracing-traced/pom.xml:  <parent>
>>> 
>>> I'll fix mp-metrics-gauge while I'm dealing with the compile issue.
>>> 
>>> 
>>> -David
>>> 
>> 
>> 

Reply via email to