Until we hear back from TCK challenges and Jakarta spec leads, I went and created 2 hacks to move us forward. They should either be deleted when TCK is fixed, or we should add excludes if challenges are validated on the TCK side of things.
Meanwhile here are the 2 hacks https://github.com/apache/tomee-tck/blob/master/src/main/java/org/apache/openejb/cts/CallbackHandlerImpl.java https://github.com/apache/tomee-tck/blob/master/src/main/java/org/apache/openejb/cts/TransactionalWorkaroundLeakGuardValve.java Disclaimer lol Not happy about it, but wanted to see if we could keep going with other tests until we hear back. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Nov 17, 2020 at 4:01 AM Daniel Dias Dos Santos < [email protected]> wrote: > very good : ) > -- > > *Daniel Dias dos Santos* > Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldiasjava > Twitter: http://twitter.com/danieldiasjava > > > Em seg., 16 de nov. de 2020 às 23:43, David Jencks < > [email protected]> > escreveu: > > > Great work! > > > > It’s really nice we don’t have to hide it! > > > > David Jencks > > > > > On Nov 16, 2020, at 3:40 PM, Jean-Louis Monteiro < > > [email protected]> wrote: > > > > > > Hi community, > > > > > > Alongside with the Jakarta EE 9 work I've been doing, I tried to look > at > > > TomEE coverage for EE 8 and EE 9. They are quite close in terms of > scope. > > > The only difference is pretty much only the namespace change from javax > > to > > > jakarta. > > > > > > I looked into our EE 9 coverage with our TomEE 9 milestone and we are > > quite > > > far in terms of coverage. > > > > > > I pushed some setup changes in the dedicated > > > https://github.com/apache/tomee-tck/tree/jakartaee9-tck branch to > bring > > the > > > coverage near EE 8 coverage with TomEE (aka around 90+ %) > > > > > > The big gaps were as far as I can see around jaspic, securityapi and > jta. > > > > > > 1/ JASPIC > > > It's about authentication for containers. We don't have much but setup > > > because we rely on Tomcat's implementation. > > > We are having some issues with the setup because of the way TCK is > built > > > for jaspic. I've been able to workaround some, but I also got hit by > TCK > > > issues. > > > See TomEE tickets > > > > > > https://issues.apache.org/jira/browse/TOMEE-2923 > > > https://issues.apache.org/jira/browse/TOMEE-2924 > > > https://issues.apache.org/jira/browse/TOMEE-2925 > > > > > > 2/ Security API > > > This is about authorization and stores. > > > This time implementation is all in TomEE (see tomee-security module). > > I'll > > > try to send another email with a walk through. It's been mostly > > implemented > > > in a quick and dirty mode but it needs tests and hardening before we > can > > > call it done. With that we can cover nearly 100% coverage of TCK. > > > But, because there is a bug, we have random failures due to the way TCK > > is > > > built. I'll create a new ticket shortly to describe the issue. > > > > > > 3/ JTA > > > We used to be covering 100% but we are down to 70% because of the > > addition > > > of @Transactional CDI tests. I again looked into our implementation and > > the > > > tests and found again issues with the TCK > > > > > > See ticket https://issues.apache.org/jira/browse/TOMEE-2921 > > > > > > I'll continue to dig into the other areas. > > > Especially everything related to Tomcat should be closer to 100% than > it > > is > > > today (JSTL, JSP, Servlet and WebSockets). > > > > > > If you want to help and look at them, that'd be great. > > > Basically follow the steps to run the TCK locally as described here > > > https://github.com/apache/tomee-tck > > > > > > and run > > > > > > com.sun.ts.tests.jstl > > > com.sun.ts.tests.jsp > > > com.sun.ts.tests.servlet > > > com.sun.ts.tests.websocket > > > > > > Then go ahead and investigate. Feel free to create a ticket or at least > > > shoot something in the mailing list so we don't duplicate the efforts. > > > > > > Hope it helps > > > -- > > > Jean-Louis Monteiro > > > http://twitter.com/jlouismonteiro > > > http://www.tomitribe.com > > > > >
