rmannibucau commented on pull request #759: URL: https://github.com/apache/tomee/pull/759#issuecomment-768446509
Hi @rzo1 , from a quick review I got these points/questions but since I'm using way less TomEE it can not be relevant: 1. junit-jupiter-api should be in scope provided to let user fully decide about the version (whatever transitive dep tree he has) 2. you likely want @ExtendWtih to be replaced with @WithOpenEJB or whatever alias annotation you want 3. This part of our testing is very rarely used so wonder if it shouldn't be skipped for junit5 in favor of application composer, EJBContainer and tomee embedded flavors which are likely more mainstream and require less boilerplate code and does not use the legacy InitialContext to start the container. Hope it helps a bit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
