rzo1 commented on a change in pull request #767:
URL: https://github.com/apache/tomee/pull/767#discussion_r595489470



##########
File path: container/openejb-core/pom.xml
##########
@@ -580,6 +580,22 @@
       <groupId>org.apache.xbean</groupId>
       <artifactId>xbean-bundleutils</artifactId>
     </dependency>
+    <dependency>

Review comment:
       I think it would be (a) cleaner and (b) could allow user's to exclude 
the compile dependencies towards junit4  - so +1 for `openejb-junit5`. 
   
   Could also include the classes from `openejb-junit5-backward` (was not 
released yet -> so no problem in renaming / dropping it), so we have all junit 
5 related things in one module. wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to