rzo1 commented on a change in pull request #767:
URL: https://github.com/apache/tomee/pull/767#discussion_r596145338



##########
File path: container/openejb-core/pom.xml
##########
@@ -580,6 +580,22 @@
       <groupId>org.apache.xbean</groupId>
       <artifactId>xbean-bundleutils</artifactId>
     </dependency>
+    <dependency>

Review comment:
       Just moved everything into `openejb-junit5`. 
   
   Should we also include the contents of `openejb-junit5-backward` in this new 
 `openejb-junit5` module? We haven't released it yet, so it wouldn't bother 
anyone.
   
   Would bring a dependency towards the legacy testing stuff:
   
   ```
    <dependency>
               <groupId>${project.groupId}</groupId>
               <artifactId>openejb-junit</artifactId>
               <version>${project.version}</version>
           </dependency>
   ```
   
   Might be cleaner without it? wdyt @rmannibucau ?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to