Hi all, Good progress thanks to some fixes Jon applied. https://tck.work/tomee/project?id=11118
Similar results with JDK 8 / 11 and 17. I need to compare the failures, but most likely same results. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Sep 22, 2021 at 9:48 AM Jean-Louis Monteiro < [email protected]> wrote: > Corba from 9.x and onward can go away. > In TomEE, we would need to discuss but it's still required per spec. > > In terms of JDK 17 support, I went and worked a bit on that and created a > separate setup to run the TCK for TomEE 8.x / EE 8. > https://tck.work/tomee/build?id=1632238261340 > > We need to work on the proxy issue and a couple of other minor issues but > it gives a status of the situation. > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Mon, Sep 20, 2021 at 8:11 PM Zowalla, Richard < > [email protected]> wrote: > >> Correction: in favour for keeping ist in 8.x.x. and maybe remove it in >> the next major version. Grüess it requires a separate discussion... >> ________________________________ >> Von: Zowalla, Richard <[email protected]> >> Gesendet: Montag, 20. September 2021 19:36:22 >> An: [email protected] >> Betreff: Re: TomEE & Java 17 >> >> don't know. David was hard in favour for it (feature removal in the >> next major version, i.e. 9.x.x) - at least this was the discussion in >> Nov 2020. >> >> Am Montag, dem 20.09.2021 um 19:14 +0200 schrieb Thomas Andraschko: >> > do we really need corba anymore? >> > >> > Am Mo., 20. Sept. 2021 um 18:53 Uhr schrieb Zowalla, Richard < >> > [email protected]>: >> > >> > > I think that there are two different ideas / thoughts in here: >> > > >> > > (a) JDK / JRE 17 Runtime: Be able to deploy and operate a TomEE >> > > with a >> > > Java 17 environment. This might be solvable by adding JVM options >> > > (as >> > > mentioned by Thiago and Vicente) or doing some rework of the proxy >> > > factory (looks like a solution without the JVM flags as mentioned >> > > by >> > > Jon) >> > > >> > > (b) _Compiling_ TomEE with JDK 11+ >> > > >> > > For (b) and Corba: >> > > >> > > I had worked on it a in 2020 and had two drafts. In May, we had >> > > some >> > > issues with a force push to master, which closed / killed all open >> > > PRs, >> > > which render the diff nearly useless. The drafts: >> > > >> > > - https://github.com/apache/tomee/pull/713 (use byte code >> > > generation at >> > > build time -> drawbacks as mentioned by Romain) >> > > >> > > - https://github.com/apache/tomee/pull/792 (using SPI to lookup a >> > > corba >> > > integration module, which can be compiled with Java 8 and is not >> > > included in the main tomee project. I guess it would require some >> > > cleanup / update and the open tasks adressed. >> > > >> > > >> > > PR 721 had some open questions, which I couldn't resolve at the >> > > time it >> > > was created. It might be worth to pick up the work on a J11+ build. >> > > The >> > > mail discussion is located here [1]. >> > > >> > > Gruss >> > > Richard >> > > >> > > >> > > >> > > [1] https://www.mail-archive.com/[email protected]/msg14097.html >> > > >> > > Am Montag, dem 20.09.2021 um 10:28 -0600 schrieb Memo Díaz Solis: >> > > > I just tested by myself (regarding the CORBA stuff) and of >> > > > course >> > > > got the >> > > > issue you mentioned. Is there any alternative besides the >> > > > glassfish >> > > > jar you >> > > > guys might know? or do we want to remove CORBA at all? >> > > > <dependency> >> > > > <groupId>org.glassfish.packager</groupId> >> > > > <artifactId>glassfish-corba-omgapi</artifactId> >> > > > <version></version> >> > > > </dependency> >> > > > >> > > > El lun, 20 sept 2021 a las 9:42, Vicente Rossello (< >> > > > [email protected]>) >> > > > escribió: >> > > > >> > > > > Hi, >> > > > > >> > > > > My two cents... >> > > > > >> > > > > I've tried the examples, don't know how to fix it permanently, >> > > > > but >> > > > > I've >> > > > > noticed two things: >> > > > > * Lombok should be upgraded to 1.18.20 to be able to compile >> > > > > with >> > > > > JDK16+ ( >> > > > > https://projectlombok.org/changelog ) >> > > > > * OrbFactory does not compile in JDK11+ as well. I don't really >> > > > > know if >> > > > > CORBA is still used by anyone >> > > > > >> > > > > I've been running tomee in JDK17 for some time now, everything >> > > > > works fine >> > > > > (there are 4 add-opens in catalina.bat / catalina.sh). >> > > > > >> > > > > On Mon, Sep 20, 2021 at 1:21 PM Zowalla, Richard < >> > > > > [email protected]> wrote: >> > > > > >> > > > > > Thanks for the additional hint. It fixes the test, but I >> > > > > > still >> > > > > > think, >> > > > > > that we should make a permanent (code-based) fix ;) >> > > > > > >> > > > > > I have created a related JIRA: >> > > > > > >> > > > > > - https://issues.apache.org/jira/browse/TOMEE-3795 >> > > > > > >> > > > > > In addition, it looks like >> > > > > > >> > > > > > - https://issues.apache.org/jira/browse/TOMEE-2744 >> > > > > > >> > > > > > is another thingy for J16 / J17. >> > > > > > >> > > > > > Perhaps we should create a tracking issue (JDK17 >> > > > > > compatibility) >> > > > > > to >> > > > > > aggregate the different issues to tackle. >> > > > > > >> > > > > > Am Montag, dem 20.09.2021 um 07:45 -0300 schrieb Thiago >> > > > > > Henrique >> > > > > > Hupner: >> > > > > > > The easy fix is to replace the illegal access to - - add- >> > > > > > > opens >> > > > > > > and - >> > > > > > > - >> > > > > > > add-exports. >> > > > > > > >> > > > > > > The exception message includes which one is required. >> > > > > > > >> > > > > > > Em seg., 20 de set. de 2021 07:34, Zowalla, Richard < >> > > > > > > [email protected]> escreveu: >> > > > > > > >> > > > > > > > I think that's the approach taken by the guys at >> > > > > > > > deltaspike >> > > > > > > > in >> > > > > > > > Thomas' >> > > > > > > > link [1] (and the related PR in [2]). >> > > > > > > > >> > > > > > > > [1] https://issues.apache.org/jira/browse/DELTASPIKE-1432 >> > > > > > > > [2] https://github.com/apache/deltaspike/pull/119 >> > > > > > > > >> > > > > > > > Am Montag, dem 20.09.2021 um 11:09 +0100 schrieb Jonathan >> > > > > > > > Gallimore: >> > > > > > > > > I had a very quick look - I wonder if we simply need to >> > > > > > > > > move to >> > > > > > > > > MethodHandles.Lookup.defineClass(): >> > > > > > > > > >> > > >> https://docs.oracle.com/javase/9/docs/api/java/lang/invoke/MethodHandles.Lookup.html#defineClass-byte:A- >> > > > > > > > > in the LocalBeanProxyFactory. There's likely a couple >> > > > > > > > > of >> > > > > > > > > other >> > > > > > > > > libraries >> > > > > > > > > that TomEE uses that do similar things, such as OWB and >> > > > > > > > > OpenJPA, >> > > > > > > > > so >> > > > > > > > > we'll >> > > > > > > > > need to check that they do the right thing in Java 17 >> > > > > > > > > as >> > > > > > > > > well. >> > > > > > > > > >> > > > > > > > > Jon >> > > > > > > > > >> > > > > > > > > On Mon, Sep 20, 2021 at 9:08 AM Zowalla, Richard < >> > > > > > > > > [email protected]> wrote: >> > > > > > > > > >> > > > > > > > > > Hi ladies, >> > > > > > > > > > >> > > > > > > > > > I wanted to start a discussion about TomEE and its >> > > > > > > > > > Java >> > > > > > > > > > 17 >> > > > > > > > > > compatibility. >> > > > > > > > > > >> > > > > > > > > > I did some tests in one of our demo projects It looks >> > > > > > > > > > like that >> > > > > > > > > > " >> > > > > > > > > > --illegal-access=permit" was removed in Java 17, >> > > > > > > > > > which >> > > > > > > > > > leads to >> > > > > > > > > > some InaccessibleObjectException [1]. >> > > > > > > > > > >> > > > > > > > > > Does anybody know, if there are solutions / >> > > > > > > > > > workarounds >> > > > > > > > > > for it >> > > > > > > > > > in >> > > > > > > > > > Java >> > > > > > > > > > 17 or do we need to fix it? If so: how? ;) >> > > > > > > > > > >> > > > > > > > > > I bet, that many other frameworks / containers will >> > > > > > > > > > run >> > > > > > > > > > in this >> > > > > > > > > > issue, >> > > > > > > > > > so maybe someone already thought about a possible >> > > > > > > > > > solution? >> > > > > > > > > > Discussion >> > > > > > > > > > seems to be "hot" [2]. >> > > > > > > > > > >> > > > > > > > > > Gruss >> > > > > > > > > > Richard >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > [1] >> > > > > > > > > > >> > > https://gist.github.com/rzo1/5c1d0724a700e262a2e2824ded9f32ab >> > > > > > > > > > [2] >> > > > > > > > > > >> https://twitter.com/delabassee/status/1438446396865224705 >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > -- >> > > Richard Zowalla, M.Sc. >> > > Research Associate, PhD Student | Medical Informatics >> > > >> > > Hochschule Heilbronn – University of Applied Sciences >> > > Max-Planck-Str. 39 >> > > D-74081 Heilbronn >> > > phone: +49 7131 504 6791 (zur Zeit nicht via Telefon erreichbar) >> > > mail: [email protected] >> > > web: https://www.mi.hs-heilbronn.de/ >> > > >> -- >> Richard Zowalla, M.Sc. >> Research Associate, PhD Student | Medical Informatics >> >> Hochschule Heilbronn – University of Applied Sciences >> Max-Planck-Str. 39 >> D-74081 Heilbronn >> phone: +49 7131 504 6791 (zur Zeit nicht via Telefon erreichbar) >> mail: [email protected] >> web: https://www.mi.hs-heilbronn.de/ >> >
