tichovz commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873054636
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final
Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value)
{
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME,
FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment
}{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee";, name =
"web-fragment")
Review Comment:
I added the web-fragment part to ObjectFactory$JAXB, but I did not solve the
issue, because the org.apache.openejb.config.ReadDescriptors.mergeWebFragments
calls JaxbJavaee.unmarshall which uses the NoSourceFilter.
It does not translate the namespace "https://jakarta.ee/xml/ns/jakartaee"; to
"http://java.sun.com/xml/ns/javaee";.
So what would I have to do?
1. change ReadDescriptors.mergeWebFragments to call
JaxbJavaee.unmarshallJavaee which changes the namespace
2. change the NoSourceFilter to change the jakarta namespace as well not
only the "http://xmlns.jcp.org/xml/ns/javaee";
3. anything else
I think I might remove the web-fragment part from ObjectFactory$JAXB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
