Hi, it's about the same Jira Issue, so it's fine to use this pull request.
Many thanks for your contribution! Gruß Richard ________________________________ Von: Zoltán Tichov <[email protected]> Gesendet: Samstag, 14. Mai 2022 21:16:03 An: [email protected] Betreff: Re: [GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824 Hi! I resolve the issue, do I need to make a new pull request? Thanks: Zoltán On Sat, May 14, 2022 at 7:31 PM GitBox <[email protected]> wrote: > > rzo1 commented on code in PR #883: > URL: https://github.com/apache/tomee/pull/883#discussion_r873055259 > > > ########## > > container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java: > ########## > @@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final > Webservices value) { > public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig > value) { > return new JAXBElement<FacesConfig>(_FacesConfig_QNAME, > FacesConfig.class, null, value); > } > + > + /** > + * Create an instance of {@link JAXBElement }{@code <}{@link > WebFragment }{@code >}} > + */ > + @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee";, > name = "web-fragment") > > Review Comment: > Thanks for the comment. I think, that the best way would be to follow > up on the list. @dblevins might have some thoughts / insights here. > > Often the best way to get answers / details is to ask on the list. The > cool thing is, that the list archive will have this information years later. > > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: [email protected] > > For queries about this service, please contact Infrastructure at: > [email protected] > >
