Quick update ... I managed to finish the SmallRye OpenAPI integration. We now pass 100% of the MicroProfile OpenAPI TCK. I'm cleaning up and I'll be pushing soon. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com
On Thu, Sep 1, 2022 at 3:25 PM Jean-Louis Monteiro <[email protected]> wrote: > Hi, > > Thanks for the update. > For the command to work you need first to put the module back in the > reactor > > https://github.com/apache/tomee/blob/main/tck/microprofile-tck/pom.xml#L39 > > It's currently commented out. > > Can you try it and see if it works? > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Wed, Aug 31, 2022 at 7:59 AM Zoltán Tichov <[email protected]> > wrote: > >> Hi! >> >> When I tried to run 'mvn clean install -pl >> tck/microprofile-tck/opentracing', I received the following error message: >> Could not find the selected project in the reactor: >> tck/microprofile-tck/opentracing >> However I ran the tests in NetBeans and all tests was failed. Is this >> normal yet? I have not changed any code yet. >> I used openjdk 17 in NetBeans, is this appropriate or should I change to >> openjdk 11? >> -- >> Zoltán >> >> >> On Wed, Aug 24, 2022 at 2:42 PM Jean-Louis Monteiro < >> [email protected]> wrote: >> >> > Awesome. >> > >> > So lemme start with some pointers. >> > >> > The MicroProfile integration code sits in this module >> > >> > >> https://github.com/apache/tomee/tree/main/tomee/tomee-microprofile/mp-common/src/main/java/org/apache/tomee/microprofile >> > You have one subpackage per MicroProfile specification. >> > >> > The TomEEMicroProfileService registers the TomEEMicroProfileListener >> which >> > is responsible for wiring all extensions for each specification. >> > >> > The TCK setup is located here >> > https://github.com/apache/tomee/tree/main/tck/microprofile-tck >> > Same as previously, one module per specification. The OpenTracing is >> there. >> > >> > Basically, if you add it back to the reactor, Maven will run the >> > OpenTracing TCK. >> > >> > You can do `mvn clean install -DskipTests` and then `mvn clean install >> -pl >> > tck/microprofile-tck/opentracing` >> > There is a tck-dev.xml you can use to run individual or all tests in the >> > IDE (TestNG based). >> > >> > Let's start this way and lemme know what you think and if you need more >> > help >> > >> > -- >> > Jean-Louis Monteiro >> > http://twitter.com/jlouismonteiro >> > http://www.tomitribe.com >> > >> > >> > On Wed, Aug 24, 2022 at 1:45 PM Zoltán Tichov <[email protected]> >> > wrote: >> > >> > > Hi! >> > > >> > > Then I'd rather continue the OpenTracing integration, so I'd be happy >> if >> > > you could help me to start it. >> > > >> > > Zoltán Tichov >> > > >> > > On Wed, Aug 24, 2022 at 12:49 PM Jean-Louis Monteiro < >> > > [email protected]> wrote: >> > > >> > > > I have started OpenTracing so you have some basics to continue if >> you >> > > want >> > > > to. >> > > > The TCK setup is done and some integration is also done. >> > > > >> > > > Does that sound good? >> > > > >> > > > Fault tolerance and OpenAPI are not started so it might be a bit >> > > > challenging to start from scratch. But either way I am happy to >> help. >> > > > >> > > > >> > > > -- >> > > > Jean-Louis Monteiro >> > > > http://twitter.com/jlouismonteiro >> > > > http://www.tomitribe.com >> > > > >> > > > >> > > > On Tue, Aug 23, 2022 at 4:55 PM Zoltán Tichov < >> [email protected] >> > > >> > > > wrote: >> > > > >> > > > > Hi! >> > > > > >> > > > > I want to work on any of them. >> > > > > >> > > > > -- >> > > > > Zoltán Tichov >> > > > > >> > > > > On Tue, Aug 23, 2022 at 2:39 PM Jean-Louis Monteiro < >> > > > > [email protected]> wrote: >> > > > > >> > > > > > Hi, >> > > > > > >> > > > > > Was looking for the last thread to pull up, but it's pretty far >> > back >> > > > and >> > > > > > misses many different things. So I decided to create a new >> thread >> > as >> > > a >> > > > > > follow up. >> > > > > > >> > > > > > Since then, we worked a lot on Jakarta EE 9 compatibility and we >> > are >> > > > > close >> > > > > > enough. So we can now focus on MicroProfile to catch up with the >> > > latest >> > > > > > available version. >> > > > > > >> > > > > > So far, >> > > > > > >> > > > > > - rest-client using CXF is fully integrated and compatible. >> No >> > > > failure >> > > > > > - metrics using SmallRye. No failure. >> > > > > > - health using SmallRye. No failure >> > > > > > - jwt using TomEE implementation. 22 failures mainly key >> parsing >> > > so >> > > > > not >> > > > > > a big deal. David is on it >> > > > > > - config using SmallRye. Currently 2 failures but PRs sent >> and >> > as >> > > > soon >> > > > > > as we can get a new release, it should be good. >> > > > > > >> > > > > > Currently missing >> > > > > > >> > > > > > >> > > > > > - OpenTracing >> > > > > > - Fault tolerance >> > > > > > - OpenAPI >> > > > > > >> > > > > > I started adding some integration for them but they don't pass >> the >> > > TCK. >> > > > > The >> > > > > > TCK are all set up with a base configuration. You just need to >> add >> > > the >> > > > > > module in the Maven reactor to run them. >> > > > > > >> > > > > > If you guys wanna work on one of them, let me know and I can >> help. >> > > > > > >> > > > > > -- >> > > > > > Jean-Louis Monteiro >> > > > > > http://twitter.com/jlouismonteiro >> > > > > > http://www.tomitribe.com >> > > > > > >> > > > > >> > > > >> > > >> > >> >
