Hey Jonathan, I looked at the PRs and they looked good. I'd probably just create a small unit test to serialize and deserialize the objects to make sure everything in it is serializable. Not talking about a full integration test with JASPIC and @LoginToContinue, just a plain unit test. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com
On Thu, Jun 8, 2023 at 6:12 PM Richard Zowalla <rich...@zowalla.com> wrote: > Hi, > > Thanks for the PRs. > > Have you synced your GitHub Account and enabled 2FA? That should add you > to the necessary groups. > > You can check via https://gitbox.apache.org/boxer/ > > Gruß > Richard > > Am 8. Juni 2023 17:36:14 MESZ schrieb "Jonathan S. Fisher" < > exabr...@gmail.com>: > >Thank you Jean-Louis, > > > >I have opened three PRs: > > > >https://github.com/apache/tomee/pull/1053 > >https://github.com/apache/tomee/pull/1054 > >https://github.com/apache/tomee/pull/1055 > > > >Also, I should be committer status (AFAIK ), but I'm unable to push to the > >github repository directly. Not sure if that can be fixed. > > > >Thank you, > > > > > >On Wed, May 31, 2023 at 9:43 AM Jean-Louis Monteiro < > >jlmonte...@tomitribe.com> wrote: > > > >> Thanks Jonathan. > >> Of course, go ahead and push it. > >> > >> We can still run the TCK and look if it breaks or you can run them (just > >> this part) if you have the setup locally. > >> -- > >> Jean-Louis Monteiro > >> http://twitter.com/jlouismonteiro > >> http://www.tomitribe.com > >> > >> > >> On Wed, May 31, 2023 at 4:27 PM Jonathan S. Fisher <exabr...@gmail.com> > >> wrote: > >> > >> > Hello Tomee team, > >> > > >> > We found a bug that I plan to fix and I wanted to make sure my > approach > >> is > >> > ok before committing. Currently on tomee-8.0.14 but it likely affects > all > >> > tomee ee8+ versions. > >> > > >> > We're trying out @LoginToContinue (finally) and migrating away from > the > >> old > >> > request.login(..) method: > >> > > >> > @CustomFormAuthenticationMechanismDefinition( > >> > loginToContinue = @LoginToContinue(loginPage = "/login", > >> > useForwardToLogin = true)) > >> > @FacesConfig > >> > @ApplicationScoped > >> > public class ApplicationConfig { > >> > } > >> > > >> > We got this exception: https://pastebin.com/KqbX2uFA > >> > > >> > This appears to be because > org.apache.tomee.security.http.SavedRequest is > >> > not Serializable, so it should be an easy fix. > >> > > >> > If I log a JIRA ticket, what is the current process for committing? > >> > > >> > Thank you! > >> > > >> > -- > >> > Jonathan | exabr...@gmail.com > >> > Pessimists, see a jar as half empty. Optimists, in contrast, see it as > >> half > >> > full. > >> > Engineers, of course, understand the glass is twice as big as it > needs to > >> > be. > >> > > >> > > > > > >-- > >Jonathan | exabr...@gmail.com > >Pessimists, see a jar as half empty. Optimists, in contrast, see it as > half > >full. > >Engineers, of course, understand the glass is twice as big as it needs to > >be. >
