Strange, I waited for CI to complete before I merged. btw this was part of a second ticket I implemented... we use the hell out of JMX to monitor *every* part of our production stack. We noticed TomEE doesn't give you the actual parameter names, so we called into parameter.getName() instead of generating arg0, arg1, etc.
I'll take a look and fix today. On Sat, Jun 10, 2023 at 2:21 AM Richard Zowalla <[email protected]> wrote: > Looks like we have a regression with these newly added tests. Surefire > complains because they cannot be executed (on main, 8.x and 9.x: > https://ci-builds.apache.org/job/Tomee/job/tomee-9.x-build-quick/37/ > > Gruß > Richard > > Am 8. Juni 2023 17:36:14 MESZ schrieb "Jonathan S. Fisher" < > [email protected]>: > >Thank you Jean-Louis, > > > >I have opened three PRs: > > > >https://github.com/apache/tomee/pull/1053 > >https://github.com/apache/tomee/pull/1054 > >https://github.com/apache/tomee/pull/1055 > > > >Also, I should be committer status (AFAIK ), but I'm unable to push to the > >github repository directly. Not sure if that can be fixed. > > > >Thank you, > > > > > >On Wed, May 31, 2023 at 9:43 AM Jean-Louis Monteiro < > >[email protected]> wrote: > > > >> Thanks Jonathan. > >> Of course, go ahead and push it. > >> > >> We can still run the TCK and look if it breaks or you can run them (just > >> this part) if you have the setup locally. > >> -- > >> Jean-Louis Monteiro > >> http://twitter.com/jlouismonteiro > >> http://www.tomitribe.com > >> > >> > >> On Wed, May 31, 2023 at 4:27 PM Jonathan S. Fisher <[email protected]> > >> wrote: > >> > >> > Hello Tomee team, > >> > > >> > We found a bug that I plan to fix and I wanted to make sure my > approach > >> is > >> > ok before committing. Currently on tomee-8.0.14 but it likely affects > all > >> > tomee ee8+ versions. > >> > > >> > We're trying out @LoginToContinue (finally) and migrating away from > the > >> old > >> > request.login(..) method: > >> > > >> > @CustomFormAuthenticationMechanismDefinition( > >> > loginToContinue = @LoginToContinue(loginPage = "/login", > >> > useForwardToLogin = true)) > >> > @FacesConfig > >> > @ApplicationScoped > >> > public class ApplicationConfig { > >> > } > >> > > >> > We got this exception: https://pastebin.com/KqbX2uFA > >> > > >> > This appears to be because > org.apache.tomee.security.http.SavedRequest is > >> > not Serializable, so it should be an easy fix. > >> > > >> > If I log a JIRA ticket, what is the current process for committing? > >> > > >> > Thank you! > >> > > >> > -- > >> > Jonathan | [email protected] > >> > Pessimists, see a jar as half empty. Optimists, in contrast, see it as > >> half > >> > full. > >> > Engineers, of course, understand the glass is twice as big as it > needs to > >> > be. > >> > > >> > > > > > >-- > >Jonathan | [email protected] > >Pessimists, see a jar as half empty. Optimists, in contrast, see it as > half > >full. > >Engineers, of course, understand the glass is twice as big as it needs to > >be. > -- Jonathan | [email protected] Pessimists, see a jar as half empty. Optimists, in contrast, see it as half full. Engineers, of course, understand the glass is twice as big as it needs to be.
