sbp commented on issue #153: URL: https://github.com/apache/tooling-trusted-release/issues/153#issuecomment-3001118343
Resolved by 91060481163985aee42b13aefca3f80726324c85. We automatically detect all `.rat-excludes` and `rat-excludes.txt` files at any level in `.tar.gz` and `.zip` archives. The archive must have one top level directory to give to RAT, otherwise it fails. We use the glob style of excludes against full paths; the syntax we use is that of `.gitignore`, which may not be 100% compatible with RAT. We do this because the RAT CLI expects matches against filenames, not against whole paths, but observed project files use whole paths. We could avoid going through the RAT CLI instead, but the present approach is hopefully viable enough for alpha. Checks are currently advisory, so even if every file has an associated check error it is still possible to progress to the vote phase from the compose phase. We plan to add a mode, tracked by #186, where this would be forbidden, but even that would still be optional, i.e. just an extra step to ensure that promotion of files with errors does not happen by mistake. Therefore the suggested feature of adding a separate set of ignore patterns, presumably in the ATR interface, isn't necessary at present. I have added it as #187, however, so that we can track it for a later development stage. Thanks for the report! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tooling.apache.org For additional commands, e-mail: dev-h...@tooling.apache.org
