sanjana2505006 commented on PR #481: URL: https://github.com/apache/tooling-trusted-releases/pull/481#issuecomment-3733445547
> @sanjana2505006 I don't understand commit [55f832f](https://github.com/apache/tooling-trusted-releases/commit/55f832fa45e3eff7d04d78a116db3c28605f6412). Not only does its content not match its commit message, but the functonality that it adds is not called for by #477 or any other issue, and actually makes this PR conflict with the documentation that it provides in commit [d8ce1f6](https://github.com/apache/tooling-trusted-releases/commit/d8ce1f6bcf3a53911f6915c64376f6afd0454a14): > > > Files that do not contain these markers but should still be ignored can be listed in a `.atr/license-headers-ignore` file within the release directory. Each line in this file corresponds to a path pattern to ignore. I completely agree with your assessment. Commit [55f832f](https://github.com/apache/tooling-trusted-releases/commit/55f832fa45e3eff7d04d78a116db3c28605f6412) was indeed a mistake on my part. I incorrectly assumed that the project followed a pattern similar to `rat-excludes` for license headers and attempted to implement what I thought was missing functionality to match my documentation draft. I recognise now that this was unrequested scope creep and that the commit message was misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
