sbp commented on PR #481: URL: https://github.com/apache/tooling-trusted-releases/pull/481#issuecomment-3756557309
@sanjana2505006 Thanks! Despite the progress, there are still several core problems: * The changes [do not pass the lints](https://github.com/apache/tooling-trusted-releases/actions/runs/21008005584/job/60511315635?pr=481) * The changes [do not pass the tests](https://github.com/apache/tooling-trusted-releases/actions/runs/21008005616/job/60511315464?pr=481) * There are still 2 commits in the PR * There are merge conflicts All of these problems are blocking the acceptance of this PR. I [first mentioned that the code has not been linted or tested five days ago](https://github.com/apache/tooling-trusted-releases/pull/481#issuecomment-3733409577). Please follow steps [3 and 4 in our PR contribution guide](https://release-test.apache.org/docs/how-to-contribute#pull-request-workflow) to get linting set up. You can then run `make check` to run the lints manually. Please follow [our guide to testing](https://release-test.apache.org/docs/running-and-creating-tests) to run the tests manually. You will need to change the files in order to make both the lints and the tests pass. Please ask if you need any help with any of these things. To resolve the problem with there being two commits, you will need to squash the commits. Since you thought that you did this already, I will assume this was a simple oversight and that you can fix it, but again, if you need any help, please feel free to ask. To fix the merge commits you'll have to try rebasing your changes onto the current `main`. Rebasing and dealing with merge commits can be complicated, but again, I can offer assistance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
