alitheg commented on code in PR #825:
URL:
https://github.com/apache/tooling-trusted-releases/pull/825#discussion_r2895257806
##########
atr/worker.py:
##########
@@ -118,21 +119,25 @@ async def _execute_check_task(
f"Task {task_id} ({task_type}) has non-dict raw args {task_args}
which should represent keyword_args"
)
+ project_name = safe.ProjectName(task_obj.project_name)
+ version_name = safe.VersionName(task_obj.version_name)
+
+ # TODO: The recorder needs values but what do we do if the task doesn't
have a project name?
async def recorder_factory() -> checks.Recorder:
return await checks.Recorder.create(
checker=handler,
inputs_hash=task_obj.inputs_hash or "",
- project_name=task_obj.project_name or "",
- version_name=task_obj.version_name or "",
+ project_name=project_name or safe.ProjectName(""),
Review Comment:
Currently as in "this is a valid bug" - but, I don't believe any __check__
tasks get project_name = None which is where this is called from, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
