sbp commented on code in PR #825:
URL:
https://github.com/apache/tooling-trusted-releases/pull/825#discussion_r2896144369
##########
atr/worker.py:
##########
@@ -118,21 +119,25 @@ async def _execute_check_task(
f"Task {task_id} ({task_type}) has non-dict raw args {task_args}
which should represent keyword_args"
)
+ project_name = safe.ProjectName(task_obj.project_name)
+ version_name = safe.VersionName(task_obj.version_name)
+
+ # TODO: The recorder needs values but what do we do if the task doesn't
have a project name?
async def recorder_factory() -> checks.Recorder:
return await checks.Recorder.create(
checker=handler,
inputs_hash=task_obj.inputs_hash or "",
- project_name=task_obj.project_name or "",
- version_name=task_obj.version_name or "",
+ project_name=project_name or safe.ProjectName(""),
Review Comment:
Oh, heh, sorry. So `project_name=project_name` is okay? I guess all checks
will always have a project name and version name, so that's actually okay. Does
make me wonder if the types for the checks should be different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
