alitheg commented on code in PR #1150:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1150#discussion_r3064495078
##########
atr/post/user.py:
##########
@@ -119,17 +119,16 @@ async def _cache_session(session: web.Committer) -> None:
session_data = {
"uid": session.uid,
- "dn": getattr(session, "dn", None),
- "fullname": getattr(session, "fullname", None),
- "email": getattr(session, "email", f"{session.uid}@apache.org"),
- "isMember": getattr(session, "isMember", False),
- "isChair": getattr(session, "isChair", False),
- "isRoot": getattr(session, "isRoot", False),
- "pmcs": getattr(session, "committees", []),
- "projects": getattr(session, "projects", []),
- "mfa": getattr(session, "mfa", False),
- "roleaccount": getattr(session, "isRole", False),
- "metadata": getattr(session, "metadata", {}),
+ "dn": session.dn,
+ "fullname": session.fullname,
+ "email": session.email,
+ "isMember": session.is_member,
+ "isChair": session.is_chair,
+ "isRoot": session.is_root,
Review Comment:
I think so - there are probably other things there we don't care about but
that one is the most theoretically sensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
