sbp commented on code in PR #1150:
URL:
https://github.com/apache/tooling-trusted-releases/pull/1150#discussion_r3064649504
##########
atr/blueprints/common.py:
##########
@@ -54,24 +56,31 @@
async def authenticate() -> web.Committer:
- web_session = await asfquart.session.read()
- if web_session is None:
+ web_session = await sessions.read()
+ if not isinstance(web_session, sql.UserSession):
raise base.ASFQuartException("Not authenticated", errorcode=401)
- if (web_session.uid is None) or (not await
ldap.is_active(web_session.uid)):
- asfquart.session.clear()
+
+ if not await ldap.is_active(web_session.uid):
Review Comment:
We discussed this and we've agreed to comment it out, which I've done in the
latest commit to this PR, f0a8978728d0ce874ca73b1b3742036fa09a728c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
