sbp opened a new issue, #1160:
URL: https://github.com/apache/tooling-trusted-releases/issues/1160
In `atr.blueprints.post.typed` we have:
```python
if check_access and (enhanced_session is not None) and
(project_key_var is not None):
await enhanced_session.check_access(str(kwargs[project_key_var]))
```
This automatically blocks POSTs when the sender is not a member of the
project. However, `check_access` was never intended for POSTs: it was only
intended as a fail-early signal for GETs, to prevent users from stumbling
across functionality in the UI that they cannot then use. In other words, it
was a blanket way of ensuring that we don't have to customise pieces of pages
when, in most cases, there would be nothing left of interest to display to
users outside of a given project anyway.
In this case, the use of `check_access` causes a problem for IPMC members
who are voting in a second podling round, because they are not necessarily
members of the project (although they may be), in which case their vote, if
cast through the ATR UI, will be blocked. Votes are cast through
`atr.post.vote.selected_post` (which should be called `atr.post.vote.selected`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
