[ 
https://issues.apache.org/jira/browse/TOREE-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933109#comment-15933109
 ] 

Kevin Bates commented on TOREE-395:
-----------------------------------

I agree that this could be considered a security issue - particularly if the 
logged output is on a different server than the notebook (e.g., using JKG with 
nb2kg).

This appears to be a function of how the output stream is initialized.  
Currently it's setup using both {{Console.out}} and {{ByteArrayOutputStream}}.  
However, if I remove {{Console.out}} from the initialization of 
{{multiOutputStream}} in ScalaInterpreter.scala I still get the results in the 
notebook but do not see the results in the output logs.

I would propose that we change the initialization of {{multiOutputStream}} to 
only add {{Console.out}} if the logger reflects that debug is enabled or add a 
specific option that prevents such logged output.

Comments?

> Provide a way to disable automatic printing of results in Toree Scala
> ---------------------------------------------------------------------
>
>                 Key: TOREE-395
>                 URL: https://issues.apache.org/jira/browse/TOREE-395
>             Project: TOREE
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Kun Liu
>
> Scala REPL supports a flag, ":silent" to enable/disable automatic printing of 
> results (those messages begin with "res"). This is also supported in Spark 
> shell. But for Toree Scala kernel, this flag is not supported. Thus the 
> result of a cell would be always printed.
> But if there is any logging mechanism, the results would be recorded in a log 
> file, while this may not be desirable. For instance, a user may not want any 
> sensitive data logged when running "dataRDD.take(5)" in a cell.
> Also found the possible source codes for this:
> https://github.com/apache/incubator-toree/blob/master/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala
> There are three methods with silent: Boolean = false as parameter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to