[
https://issues.apache.org/jira/browse/TOREE-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934825#comment-15934825
]
Ryan Blue commented on TOREE-395:
---------------------------------
Thanks for continuing the discussion on this, Kevin. A few weeks ago, I posted
a [WIP pull request|https://github.com/apache/incubator-toree/pull/104] with
what we're currently using that you might be interested in. That addresses a
few issues, including this one. The approach we took was to get rid of
multiOutputStream and just use lastResultOut. Normal stderr and stdout printing
happens just fine, so I think that the only output that gets printed the writer
passed to IMain is the summary of what ran (e.g. import scala...). Your idea to
conditionally print the output to the logger should work fine, but is it really
necessary for people to see this output in the logs? I see no reason to keep it
this way.
> Provide a way to disable automatic printing of results in Toree Scala
> ---------------------------------------------------------------------
>
> Key: TOREE-395
> URL: https://issues.apache.org/jira/browse/TOREE-395
> Project: TOREE
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: Kun Liu
>
> Scala REPL supports a flag, ":silent" to enable/disable automatic printing of
> results (those messages begin with "res"). This is also supported in Spark
> shell. But for Toree Scala kernel, this flag is not supported. Thus the
> result of a cell would be always printed.
> But if there is any logging mechanism, the results would be recorded in a log
> file, while this may not be desirable. For instance, a user may not want any
> sensitive data logged when running "dataRDD.take(5)" in a cell.
> Also found the possible source codes for this:
> https://github.com/apache/incubator-toree/blob/master/scala-interpreter/src/main/scala/org/apache/toree/kernel/interpreter/scala/ScalaInterpreter.scala
> There are three methods with silent: Boolean = false as parameter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
