[
https://issues.apache.org/jira/browse/TOREE-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007110#comment-17007110
]
ASF GitHub Bot commented on TOREE-511:
--------------------------------------
kevin-bates commented on pull request #181: [TOREE-511] Rework make jupyter
build tasks
URL: https://github.com/apache/incubator-toree/pull/181#discussion_r362650343
##########
File path: Makefile
##########
@@ -81,19 +83,15 @@ clean: VM_WORKDIR=/src/toree-kernel
clean: clean-dist
$(call RUN,$(ENV_OPTS) sbt clean)
rm -r `find . -name target -type d`
+ -rm -r `find . -name .ipynb_checkpoints -type d`
-.example-image: EXTRA_CMD?=printf "deb
http://cran.rstudio.com/bin/linux/debian jessie-cran3/" >>
/etc/apt/sources.list; apt-key adv --keyserver keys.gnupg.net --recv-key
381BA480; apt-get update; pip install jupyter_declarativewidgets==0.4.4;
jupyter declarativewidgets install --user; jupyter declarativewidgets activate;
pip install jupyter_dashboards; jupyter dashboards install --user; jupyter
dashboards activate; apt-get update; apt-get install --yes curl; curl --silent
--location https://deb.nodesource.com/setup_0.12 | sudo bash -; apt-get install
--yes nodejs r-base r-base-dev; npm install -g bower;
-.example-image:
- @-docker rm -f examples_image
- @docker run -t --user root --name examples_image \
- $(IMAGE) bash -c '$(EXTRA_CMD)'
- @docker commit examples_image $(EXAMPLE_IMAGE)
- @-docker rm -f examples_image
- touch $@
+clean-images:
+ -rm -r .toree-dev-image
+ -rm -r .binder-image
Review comment:
Should this target actually remove the images as well? If so,
`clean-images` would depend on `clean-toree-dev-image` and `clean-binder-image`
- with those added to `.PHONY` and ignore the same comment regarding
`clean-images` since it now depends on other targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rework "make dev/make jupyter" build tasks
> ------------------------------------------
>
> Key: TOREE-511
> URL: https://issues.apache.org/jira/browse/TOREE-511
> Project: TOREE
> Issue Type: Task
> Components: Build
> Reporter: Luciano Resende
> Assignee: Luciano Resende
> Priority: Major
> Fix For: 0.4.0
>
>
> Toree has `make dev` and `make jupyter` commands that are using some old
> dependencies and some weird way to build them. We should create a docker
> file that extends from `jupyter/all-spark-notebook` to make maintenance
> easier.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
