> On Dec 1, 2016, at 4:02 PM, Dan Kirkwood <dang...@apache.org> wrote:
>
> Hello All,
>
> I've prepared another release for v1.8.0 (RC3)
>
> Changes since 1.7.0:
> https://github.com/apache/incubator-trafficcontrol/compare/RELEASE-1.7.0...RELEASE-1.8.0-RC3
>
> This corresponds to git:
> Hash: daf585eacdcae4f57d60f14b4b6170b004058559
> Tag: RELEASE-1.8.0-RC3
>
More nitpicking :).
1) Your .md5 is slightly unusual, pretty sure most ASF projects use a format
like
fedora (15:44) 271/0 $ md5sum
incubator-trafficcontrol-1.8.0.4569.daf585ea.tar.gz
d51294f20b2c19ab024cbb214740c498
incubator-trafficcontrol-1.8.0.4569.daf585ea.tar.gz
2) For shits and giggles, throw in the SHA1 sum too (it’s not required, but
suggested).
3) if it was me, I’d drop the commit ID :). I assume you are tagging the git
repo with the release version anyways, right ?
4) I’d much prefer if the tar-ball unpacked into e.g.
incubator-trafficcontrol-1.8.0-RC3 or some such.
5) There are still quite a lot of files lacking Apache License. See some
examples below. I can give a complete list if you need. Also, I couldn’t find
an exclude file to feed to the RAT app, that might also be something to
provide? There are legitimate cases where you can’t put a license into files,
such as the JSON files.
6) Continuing on 5), there’s a few things that looks like imports, but I don’t
see a blurb in NOTICE for ‘em. E.g.
traffic_monitor/experimental/vendor/github.com/davecheney/gmx/
<http://github.com/davecheney/gmx/>
traffic_monitor/experimental/vendor/gopkg.in/fsnotify.v1
I’m not 100% certain what the Incubator release policies are right now, but I’d
be surprised if they would not have a beef with the large amounts of source
files without license or attributions.
Cheers,
— leif
traffic_monitor/.classpath
traffic_monitor/.pmd
traffic_monitor/.project
traffic_monitor/README.md
traffic_monitor/pom.xml
traffic_monitor/build/pmd/ruleset.xml
traffic_monitor/etc/_astats
traffic_monitor/etc/_astats_static
traffic_monitor/etc/ats_sim.js
traffic_monitor/experimental/common/adapter/adapter.go
traffic_monitor/experimental/common/crstates/crstates.go
traffic_monitor/experimental/common/fetcher/fetcher.go
traffic_monitor/experimental/common/handler/handler.go
traffic_monitor/experimental/common/instrumentation/instrumentation.go
traffic_monitor/experimental/common/log/log.go
traffic_monitor/experimental/common/poller/poller.go
traffic_monitor/experimental/conf/traffic_ops.cfg
traffic_monitor/experimental/traffic_monitor/build.sh
traffic_monitor/experimental/traffic_monitor/index.html
traffic_monitor/experimental/traffic_monitor/sorttable.js
traffic_monitor/experimental/traffic_monitor/traffic_monitor-example-config.json
traffic_monitor/experimental/traffic_monitor/traffic_monitor.go
traffic_monitor/experimental/traffic_monitor/version.go
traffic_monitor/experimental/traffic_monitor/cache/astats.go
traffic_monitor/experimental/traffic_monitor/cache/astats.json
traffic_monitor/experimental/traffic_monitor/cache/astats_test.go
traffic_monitor/experimental/traffic_monitor/cache/cache.go
traffic_monitor/experimental/traffic_monitor/config/config.go
traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go
traffic_monitor/experimental/traffic_monitor/deliveryservicedata/stat.go
traffic_monitor/experimental/traffic_monitor/enum/enum.go
traffic_monitor/experimental/traffic_monitor/health/cache_health.go
traffic_monitor/experimental/traffic_monitor/manager/cacheavailablestatus.go
traffic_monitor/experimental/traffic_monitor/manager/datarequest.go
traffic_monitor/experimental/traffic_monitor/manager/dsstats.go
traffic_monitor/experimental/traffic_monitor/manager/events.go
traffic_monitor/experimental/traffic_monitor/manager/healthresult.go
traffic_monitor/experimental/traffic_monitor/manager/lastkbpsstats.go
traffic_monitor/experimental/traffic_monitor/manager/manager.go
traffic_monitor/experimental/traffic_monitor/manager/monitorconfig.go
traffic_monitor/experimental/traffic_monitor/manager/opsconfig.go
traffic_monitor/experimental/traffic_monitor/manager/peer.go
traffic_monitor/experimental/traffic_monitor/manager/polledcaches.go
traffic_monitor/experimental/traffic_monitor/manager/stathistory.go
traffic_monitor/experimental/traffic_monitor/manager/uintman.go
traffic_monitor/experimental/traffic_monitor/peer/crstates.go
traffic_monitor/experimental/traffic_monitor/peer/crstates.json
traffic_monitor/experimental/traffic_monitor/peer/peer.go
traffic_monitor/experimental/traffic_monitor/peer/peer_test.go
traffic_monitor/experimental/traffic_monitor/srvhttp/srvhttp.go
traffic_monitor/experimental/traffic_monitor/trafficopsdata/trafficopsdata.go
traffic_monitor/experimental/traffic_monitor/trafficopswrapper/trafficopswrapper.go
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/Index.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/data/StatisticsLog.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/CacheStateRegistry.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/CacheStateUpdater.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/CacheStatisticsClient.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/DeliveryServiceStateRegistry.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/DsStati.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/EmbeddedStati.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/health/StateRegistry.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/CacheDetailsPage.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/CacheListPanel.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/DsDetailsPage.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/DsListPanel.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/EventLogPanel.html
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/components/StateDetailsPage.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/models/CacheDataModel.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/models/CacheStateModel.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/models/DsStateModel.java
traffic_monitor/src/main/java/com/comcast/cdn/traffic_control/traffic_monitor/wicket/models/StateModel.java
traffic_monitor/src/main/resources/log4j.properties
traffic_monitor/src/main/resources/version.prop
traffic_monitor/src/main/scripts/postremove.sh
traffic_monitor/src/main/webapp/style.css
traffic_monitor/src/main/webapp/test.html
traffic_monitor/src/main/webapp/WEB-INF/web.xml
traffic_monitor/src/main/webapp/css/jMenu.jquery.css
traffic_monitor/src/main/webapp/js/main.js
traffic_monitor/src/test/java/application/MonitorApplicationTest.java
traffic_monitor/src/test/java/config/CacheTest.java
traffic_monitor/src/test/java/config/ConfigHandlerTest.java
traffic_monitor/src/test/java/config/ConfigTest.java
traffic_monitor/src/test/java/config/MonitorConfigTest.java
traffic_monitor/src/test/java/config/RouterConfigTest.java
traffic_monitor/src/test/java/data/DataPointTest.java
traffic_monitor/src/test/java/data/StatisticsLogTest.java
traffic_monitor/src/test/java/health/CacheStateUpdaterTest.java
traffic_monitor/src/test/java/health/CacheStatisticsClientTest.java
traffic_monitor/src/test/java/health/DeletemeTest.java
traffic_monitor/src/test/java/health/HealthDeterminerTest.java
traffic_monitor/src/test/resources/conf/traffic_monitor_config.js
traffic_monitor/src/test/resources/db/health-params.json
traffic_monitor/src/test/resources/var/cr-config.json
traffic_monitor/src/test/resources/var/health-params.js
I stopped here, but there’s similarly large amounts of files without a license.
