[
https://issues.apache.org/jira/browse/TS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774052#action_12774052
]
Andrew Hsu commented on TS-3:
-----------------------------
For now, we can include the tcl.m4 file, but we will have to revisit this
(possibly remove the file) in the future (before our first release). The
tcl.m4 file looks like a very nice wrapper around the discovery of tclConfig.sh
which is a good thing and according to Stephane's link it looks like it is best
practice to use the m4 macros instead of calling tclConfig.sh directly.
I'm not sure why fedora does not include tcl.m4 in their package--none of the
packages provide that file. We should ask fedora to consider inclusion for
fedora 13 since fedora 12 is almost out the door.
However, we do have an open yahoo-internal ticket to remove all files from
traffic server that are from tcl/tk so that we can remove the tcl/tk license
from our LICENSE file. We have removed all except for one file, but adding
tcl.m4 would make that 2 files.
Not sure if this is a bad thing or not. I've found rivet includes tcl.m4 in
their repo:
http://svn.apache.org/viewvc/tcl/rivet/trunk/tclconfig/tcl.m4
And there is no mention of whether tcl/tk lic is compatible with alv2. Looks
like it is (standard copyright notice, "don't sue us" notice, "as is" notice),
but not sure what impact the government clause at the bottom has (need to
consult lawyer and doug):
http://www.tcl.tk/software/tcltk/license.html
I'll have a patch later this afternoon and if the patch is signed off I'll have
it committed later today.
First, lunch.
Cheers,
Andrew
> Finding TCL library
> -------------------
>
> Key: TS-3
> URL: https://issues.apache.org/jira/browse/TS-3
> Project: Traffic Server
> Issue Type: Bug
> Components: Build
> Reporter: Leif Hedstrom
> Assignee: Andrew Hsu
> Priority: Minor
> Attachments:
> 0001-TS-3-Use-TCL-macros-to-find-where-the-libs-includes-.patch
>
>
> And make the checks have some teeth. tcl.h is in /usr/lib/tclx.y on Ubuntu at
> least. This assumed TCL >= 8.4, but that's ancient already.
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 831451)
> +++ configure.ac (working copy)
> @@ -376,8 +376,13 @@
> #
> -----------------------------------------------------------------------------
> # 5. CHECK FOR HEADER FILES
>
> -AC_CHECK_HEADER([execinfo.h],[],[])
> +AC_CHECK_HEADER([execinfo.h],[],[AC_MSG_FAILURE(Cannot find execinfo.h)])
>
> +SC_PATH_TCLCONFIG
> +source $TCL_BIN_DIR/tclConfig.sh
> +CPPFLAGS="$CPPFLAGS $TCL_INCLUDE_SPEC"
> +AC_CHECK_HEADER([tcl.h],[],[AC_MSG_FAILURE(Cannot find tcl.h)])
> +
> #
> # use modular IOCORE
> #
> --
> Stephane Belmon
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
