[ 
https://issues.apache.org/jira/browse/TS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Hsu updated TS-3:
------------------------

    Attachment: TS-3-andrewhsu-001.patch

Apply patch in the traffic/trunk dir:
patch -p0 < TS-3-andrewhsu-001.patch

This patch adds 'm4/tcl.m4' file taken from tcl 8.5.7:
http://prdownloads.sourceforge.net/tcl/tcl8.5.7-src.tar.gz

And includes the macros per automake convention:
http://www.gnu.org/software/automake/manual/automake.html#Local-Macros

I've removed AC_PATH_PROG for tclsh since it is not used anywhere in the build.

I'm also assuming if a valid tclConfig.sh is found and can load properly, then 
the libraries are built properly and working.  This is because tclConfig.sh is 
a generated file from a successful build of the tcl libraries.

Also taking the time to svn:ignore aclocal.m4 since it is generated by 
configure.

I've tested on Fedora 11 64-bit and Ubuntu 9.10 32-bit.

Provided with sign-off, I will commit.

Cheers,
Andrew

> Finding TCL library
> -------------------
>
>                 Key: TS-3
>                 URL: https://issues.apache.org/jira/browse/TS-3
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: Leif Hedstrom
>            Assignee: Andrew Hsu
>            Priority: Minor
>         Attachments: 
> 0001-TS-3-Use-TCL-macros-to-find-where-the-libs-includes-.patch, 
> TS-3-andrewhsu-001.patch
>
>
> And make the checks have some teeth. tcl.h is in /usr/lib/tclx.y on Ubuntu at 
> least. This assumed TCL >= 8.4, but that's ancient already.
> Index: configure.ac
> ===================================================================
> --- configure.ac        (revision 831451)
> +++ configure.ac        (working copy)
> @@ -376,8 +376,13 @@
>  # 
> -----------------------------------------------------------------------------
>  # 5. CHECK FOR HEADER FILES
>  
> -AC_CHECK_HEADER([execinfo.h],[],[])
> +AC_CHECK_HEADER([execinfo.h],[],[AC_MSG_FAILURE(Cannot find execinfo.h)])
>  
> +SC_PATH_TCLCONFIG
> +source $TCL_BIN_DIR/tclConfig.sh
> +CPPFLAGS="$CPPFLAGS $TCL_INCLUDE_SPEC"
> +AC_CHECK_HEADER([tcl.h],[],[AC_MSG_FAILURE(Cannot find tcl.h)])
> +
>  #
>  # use modular IOCORE 
>  #
> --
> Stephane Belmon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to